Skip to content

Commit

Permalink
uncomment run command
Browse files Browse the repository at this point in the history
  • Loading branch information
cyrildiagne committed Jan 3, 2020
1 parent b27a9ff commit 0c63870
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 18 deletions.
19 changes: 10 additions & 9 deletions cmd/deploy.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package cmd
import (
"fmt"
"os"
"os/exec"
"path/filepath"

skaffoldCfg "github.com/cyrildiagne/kuda/pkg/kuda/deployer/skaffold/config"
Expand Down Expand Up @@ -78,16 +79,16 @@ func deployWithSkaffold(manifestFile string) error {
return err
}

// // Run command.
// args := []string{"run", "-f", skaffoldFile}
// cmd := exec.Command("skaffold", args...)
// cmd.Stdout = os.Stdout
// cmd.Stdin = os.Stdin
// cmd.Stderr = os.Stderr
// Run command.
args := []string{"run", "-f", skaffoldFile}
cmd := exec.Command("skaffold", args...)
cmd.Stdout = os.Stdout
cmd.Stdin = os.Stdin
cmd.Stderr = os.Stderr

// if err := cmd.Run(); err != nil {
// return err
// }
if err := cmd.Run(); err != nil {
return err
}

return nil
}
19 changes: 10 additions & 9 deletions cmd/dev.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package cmd
import (
"fmt"
"os"
"os/exec"
"path/filepath"

skaffoldCfg "github.com/cyrildiagne/kuda/pkg/kuda/deployer/skaffold/config"
Expand Down Expand Up @@ -78,16 +79,16 @@ func devWithSkaffold(manifestFile string) error {
return err
}

// // Run command.
// args := []string{"dev", "-f", skaffoldFile}
// cmd := exec.Command("skaffold", args...)
// cmd.Stdout = os.Stdout
// cmd.Stdin = os.Stdin
// cmd.Stderr = os.Stderr
// Run command.
args := []string{"dev", "-f", skaffoldFile}
cmd := exec.Command("skaffold", args...)
cmd.Stdout = os.Stdout
cmd.Stdin = os.Stdin
cmd.Stderr = os.Stderr

// if err := cmd.Run(); err != nil {
// return err
// }
if err := cmd.Run(); err != nil {
return err
}

return nil
}

0 comments on commit 0c63870

Please sign in to comment.