fix coords when specified x,y during click#5635
Merged
brian-mann merged 1 commit intodevelopfrom Nov 7, 2019
Merged
Conversation
Contributor
|
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
brian-mann
reviewed
Nov 7, 2019
|
|
||
| const viewportTargetCoords = getTopLeftCoordinates(fromElViewport) | ||
| const windowTargetCoords = getTopLeftCoordinates(fromElWindow) | ||
| const AUTwindowTargetCoords = getTopLeftCoordinates(fromAutWindow) |
Member
There was a problem hiding this comment.
this variable should really be named autWindowTargetCoords and not be capitalized, but ill approve anyway and fix it in develop
brian-mann
approved these changes
Nov 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

there was an edge case in
coordinates.jsthat did not attach x,y property tofromAUTWindowas of3.5.0we now attach x,y to fromAUTWindow when given offset coords
Closes click red target is at the wrong position in 3.5.0 #5624
User facing changelog
cy.click()click red target is at the wrong position in 3.5.0 #5624Additional details
How has the user experience changed?
during
cy.click(x, y)PR Tasks
cypress-documentation?type definitions?cypress.schema.json?