Fix types for cy.dblclick and cy.rightclick#5618
Merged
jennifer-shehane merged 4 commits intocypress-io:developfrom Nov 7, 2019
Merged
Fix types for cy.dblclick and cy.rightclick#5618jennifer-shehane merged 4 commits intocypress-io:developfrom
jennifer-shehane merged 4 commits intocypress-io:developfrom
Conversation
These two call signatures where missing for rightclick and dblclick: only the `rightclick(options?: Partial<ClickOptions>): Chainable<Subject> ` one was present. See cypress-io#5617
Contributor
|
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
kuceb
approved these changes
Nov 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User facing changelog
This PR adds the missing call signatures for dblclick and rightclick in the index.d.ts file.
Additional details
Without this change,
dblclickandrightclickcould only be used with the first call signature (rightclick(options?) in a TypeScript file.How has the user experience changed?
cypress-documentation?type definitions?cypress.schema.json?