Skip to content

Pull next_dev_version from manifest#5549

Closed
flotwig wants to merge 13 commits intodevelopfrom
next-version-in-manifest
Closed

Pull next_dev_version from manifest#5549
flotwig wants to merge 13 commits intodevelopfrom
next-version-in-manifest

Conversation

@flotwig
Copy link
Contributor

@flotwig flotwig commented Oct 31, 2019

I think we don't want to hardcode next version in the manifest of the current version. Instead, we leave the manifest as is and we could do one of the following:

  • look at the commits to determine what number to increment: major, minor or patch using semantic convention.
    or

  • get the increment from an environment variable. For example, we can assume "minor" version upgrade by default and if needed we could overwrite it on CI only if releasing a new patch or major version

  • Closes

User facing changelog

Additional details

How has the user experience changed?

PR Tasks

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 31, 2019

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

  • Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
  • Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

  • The feature/bugfix is self-documenting from within the product.
  • The change provides the end user with a way to fix their problem (no dead ends).

Functionality

  • The code works and performs its intended function with the correct logic.
  • Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
  • The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

  • The code is readable (too many nested 'if's are a bad sign).
  • Names used for variables, methods, etc, clearly describe their function.
  • The code is easy to understood and there are relevant comments explaining.
  • New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
  • There are comments containing link(s) to the addressed issue (in tests and code).

Quality

  • The change does not reimplement code.
  • There's not a module from the ecosystem that should be used instead.
  • There is no redundant or duplicate code.
  • There are no irrelevant comments left in the code.
  • Tests are testing the code’s intended functionality in the best way possible.

Internal

  • The original issue has been tagged with a release in ZenHub.

@cypress
Copy link

cypress bot commented Oct 31, 2019



Test summary

3576 0 44 0


Run details

Project cypress
Status Passed
Commit 193483a
Started Dec 11, 2019 9:22 PM
Ended Dec 11, 2019 9:27 PM
Duration 04:12 💡
OS Linux Debian - 9.8
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@flotwig
Copy link
Contributor Author

flotwig commented Oct 31, 2019

All the builds seem to work, now to fix whatever's going wrong with the commit-message-install projects...

@bahmutov
Copy link
Contributor

bahmutov commented Nov 5, 2019

similar PR #5601

@flotwig flotwig marked this pull request as draft April 20, 2020 15:12
@flotwig flotwig changed the title [WIP] Pull next_dev_version from manifest \Pull next_dev_version from manifest Apr 20, 2020
@flotwig flotwig changed the title \Pull next_dev_version from manifest Pull next_dev_version from manifest Apr 20, 2020
@jennifer-shehane
Copy link
Member

Unfortunately we have to close this issue due to inactivity. Please comment if there is new information to provide concerning the original issue and we can reopen.

@flotwig flotwig deleted the next-version-in-manifest branch January 24, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants