Fixes flaky test in rerun_spec.coffee.#5546
Merged
jennifer-shehane merged 5 commits intocypress-io:developfrom Oct 31, 2019
Merged
Fixes flaky test in rerun_spec.coffee.#5546jennifer-shehane merged 5 commits intocypress-io:developfrom
jennifer-shehane merged 5 commits intocypress-io:developfrom
Conversation
Contributor
|
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
1 task
jennifer-shehane
approved these changes
Oct 31, 2019
Member
jennifer-shehane
left a comment
There was a problem hiding this comment.
Looks good! Thanks for this. Maybe not the root of the flake, but will stop this test from being flaky.
Member
|
I'm sorry, I squashed it. I did wrong 😭 Will not do again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User facing changelog
Fixes a flaky test.
Additional details
Why was this change necessary?
This makes CI fail without reason.
What is affected by this change?
Something went wrong in compiling coffeescript to javascript. So, it is decaffeinated.
Any implementation details to explain?
n/a
How has the user experience changed?
n/a
PR Tasks
Has a PR for user-facing changes been opened incypress-documentation?Have API changes been updated in thetype definitions?Have new configuration options been added to thecypress.schema.json?