Allow passing qs parameter to cy.visit to set querystring

[flotwig]

• Closes cy.visit() and URL encoding #5034

Pre-merge Tasks

• Have tests been added/updated for the changes in this PR?
• Has a PR to cypress-documentation been submitted to document any user-facing changes? Add cy.visit() qs option cypress-documentation#2042
• Have the type definitions been updated with any user-facing API changes?
• Has the original issue been tagged with a release in ZenHub?

[cypress]

---

Test summary

3344 • 0 • 47 • 0

---

Run details

Project	cypress
Status	Passed
Commit	98fc2cf
Started	Sep 17, 2019 7:57 PM
Ended	Sep 17, 2019 8:01 PM
Duration	04:11 💡
OS	Linux Debian - 8.10
Browser	Multiple

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[jennifer-shehane]

I don't personally like the name of this argument being qs. It doesn't seem immediately obvious what qs stands for.

I liked the original issues suggestion of passing in the arg as params.

BUT, I'm also perhaps not as familiar with other existing APIs in this space - so if this is a really common convention then 🤷‍♀

[flotwig]

I don't personally like the name of this argument being qs. It doesn't seem immediately obvious what qs stands for.

I liked the original issues suggestion of passing in the arg as params.

BUT, I'm also perhaps not as familiar with other existing APIs in this space - so if this is a really common convention then woman_shrugging

I'm fine with params, I've seen it used before too. Just because request uses qs doesn't mean we have to too especially since it's a little obscure.

[flotwig]

Actually, cy.request() uses qs, so we should probably use that here too.

[jennifer-shehane]

@flotwig Oh 😞 I didn't realize this was supported in cy.request, qs it is then.