rename cy.type disableSpecialChars options
#4761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
After discussion, we'll go ahead and keep this option but...
|
kuceb
changed the title
disableSpecialCharSequences options
kuceb
changed the title
disableSpecialCharSequences optionsdisableSpecialChars options
kuceb
requested review from
brian-mann
and removed request for
brian-mann,
chrisbreiding and
jennifer-shehane
brian-mann
requested changes
Jul 23, 2019
Member
There was a problem hiding this comment.
- Can we say explicitly to "pass the option: { ... }" in the footer?
- Can we add a link to the
cy.typedocs in the footer too? https://on.cypress.io/type
Member
|
I feel a little bit like....am I missing something? The default for I reversed all of the logic and booleans in this commit 159f1d0 |
Contributor
Author
|
@jennifer-shehane nice. good catch |
brian-mann
reviewed
Jul 24, 2019
| const allChars = _.keys(Keyboard.specialChars).concat(_.keys(Keyboard.modifierChars)).join(', ') | ||
|
|
||
| expect(err.message).to.eq(`Special character sequence: '{bar}' is not recognized. Available sequences are: ${allChars}`) | ||
| expect(err.message).to.eq(`Special character sequence: '{bar}' is not recognized. Available sequences are: ${allChars} |
Member
There was a problem hiding this comment.
Approving this PR but this would be a good place to introduce template tags using the common-tags module.
brian-mann
approved these changes
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussion, we'll go ahead and keep this option but...
parseSpecialCharSequencescy.type()error message that indicates an invalid sequence and point the user to this optionclose #4287
close #4744
Docs
cy.type()renamedisableSpecialCharsopions cypress-documentation#1903