Allow circular structures to be sent over the websocket, make it an error to send circular request bodies#4407
Merged
brian-mann merged 18 commits intodevelopfrom Jun 13, 2019
Merged
Allow circular structures to be sent over the websocket, make it an error to send circular request bodies#4407brian-mann merged 18 commits intodevelopfrom
brian-mann merged 18 commits intodevelopfrom
Conversation
brian-mann
requested changes
Jun 12, 2019
Member
brian-mann
left a comment
There was a problem hiding this comment.
- use the global
ioinstead of requiring in@packages/socketin the extension. - build the extension to look at the source to ensure it's not packaging up socket.io twice
- we need to write a single "e2e / driver" test that passes in a circular dep.
- the test could be simple like something in
cypress_spec.coffeeor similar. we just need to useCypress.backend(...)and pass in an object that would cause it to normally fail
brian-mann
requested changes
Jun 13, 2019
- keep the interfaces identical - browser simply has less properties than the node variant
brian-mann
approved these changes
Jun 13, 2019
This was referenced Jul 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requestlib can't serialize a recursive body (of course), so we should warn the user that they're sending an invalid bodyThought about using
flatted(the successor tocircular-json), but jsperf shows it performs 50% slower: https://jsperf.com/flatted-vs-circularjson