Skip to content

Conversation

@jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Nov 25, 2025

  • Closes

Additional details

  • Added tar, wc, and rm to the ignoreBinaries list in knip.json. This suppresses knip warnings for these system binaries used in the size scripts. These are system binaries, not npm packages, so they shouldn't be listed as dependencies. They're standard Unix/Linux/macOS commands expected to be available.
  • Add rollup to devDeps for some component packages that were using it in scripts. They likely rely on hoisting from npm/mount-utils (which has rollup: "3.29.5")
  • Removed the "secure": "nsp check" script from webpack-preprocessor package, don't see this being run and nsp is deprecated. We use Snyk for checks.
  • Add tsx to devDependencies for webpack-preprocessor since it's called in test script.
  • Remove call to yarn types from 2 packages, I'm not sure what this was ever supposed to do as part of the test script for these 2 packages.
  • Remove codecov script from server. I don't think this is called anywhere.
  • Ignore circleci binary from knip checks as this requires local installation
  • Ignore tslint binary from knip checks. I tried to move tslint to the root package.json file as it is used in various package scripts and is today in the data-context package, but the repo basically exploded, so I just don't want to touch it.

Steps to test

  • Run yarn
  • Run yarn health-check and see no Unlisted Binaries warnings

How has the user experience changed?

N/A

PR Tasks


Note

Expands knip ignored binaries, adds rollup/tsx where used, removes unused/deprecated scripts, and bumps CircleCI cache version.

  • Configuration
    • Update knip.json ignoreBinaries to include circleci, rm, tar, tslint, wc.
    • Bump .circleci/cache-version.txt to 11-25-2025.
  • Build/Test Dependencies
  • Scripts cleanup
    • Remove deprecated secure script from npm/webpack-preprocessor.
    • Remove yarn types from test scripts in packages/frontend-shared and packages/launchpad.
    • Remove codecov script from packages/server.

Written by Cursor Bugbot for commit a9a8447. This will update automatically on new commits. Configure here.

@cypress
Copy link

cypress bot commented Nov 25, 2025

cypress    Run #67582

Run Properties:  status check passed Passed #67582  •  git commit a9a8447464: bump cache
Project cypress
Branch Review knip-health-check-followsup
Run status status check passed Passed #67582
Run duration 24m 43s
Commit git commit a9a8447464: bump cache
Committer Jennifer Shehane
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 11
Tests that did not run due to a developer annotating a test with .skip  Pending 1097
Tests that did not run due to a failure in a mocha hook  Skipped 4
Tests that passed  Passing 26698
View all changes introduced in this branch ↗︎

Warning

Partial Report: The results for the Application Quality reports may be incomplete.

UI Coverage  45.48%
  Untested elements 188  
  Tested elements 161  
Accessibility  98%
  Failed rules  4 critical   8 serious   2 moderate   2 minor
  Failed elements 101  

@jennifer-shehane jennifer-shehane changed the title chore: knip health-check followups chore: knip health-check followups to resolve unlisted binaries Nov 25, 2025
@jennifer-shehane jennifer-shehane self-assigned this Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants