-
Notifications
You must be signed in to change notification settings - Fork 3.4k
chore: knip health-check followups to resolve unlisted binaries #33009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jennifer-shehane
wants to merge
11
commits into
develop
Choose a base branch
from
knip-health-check-followsup
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
knip-health-check-followsup
|
| Run status |
|
| Run duration | 24m 43s |
| Commit |
|
| Committer | Jennifer Shehane |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
11
|
|
|
1097
|
|
|
4
|
|
|
26698
|
| View all changes introduced in this branch ↗︎ | |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
45.48%
|
|
|---|---|
|
|
188
|
|
|
161
|
Accessibility
98%
|
|
|---|---|
|
|
4 critical
8 serious
2 moderate
2 minor
|
|
|
101
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
tar,wc, andrmto the ignoreBinaries list in knip.json. This suppresses knip warnings for these system binaries used in the size scripts. These are system binaries, not npm packages, so they shouldn't be listed as dependencies. They're standard Unix/Linux/macOS commands expected to be available.rollupto devDeps for some component packages that were using it in scripts. They likely rely on hoisting fromnpm/mount-utils(which hasrollup: "3.29.5")yarn typesfrom 2 packages, I'm not sure what this was ever supposed to do as part of the test script for these 2 packages.codecovscript fromserver. I don't think this is called anywhere.circlecibinary from knip checks as this requires local installationtslintbinary from knip checks. I tried to movetslintto the rootpackage.jsonfile as it is used in various package scripts and is today in thedata-contextpackage, but the repo basically exploded, so I just don't want to touch it.Steps to test
yarnyarn health-checkand see no Unlisted Binaries warningsHow has the user experience changed?
N/A
PR Tasks
cypress-documentation?type definitions?Note
Expands knip ignored binaries, adds rollup/tsx where used, removes unused/deprecated scripts, and bumps CircleCI cache version.
knip.jsonignoreBinariesto includecircleci,rm,tar,tslint,wc..circleci/cache-version.txtto11-25-2025.[email protected]tonpm/react,npm/svelte,npm/vuedevDependencies.[email protected]tonpm/webpack-preprocessordevDependencies and use intestscript.securescript fromnpm/webpack-preprocessor.yarn typesfromtestscripts inpackages/frontend-sharedandpackages/launchpad.codecovscript frompackages/server.Written by Cursor Bugbot for commit a9a8447. This will update automatically on new commits. Configure here.