Skip to content

chore: Update v8 snapshot cache - windows #32998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 24, 2025
Merged

chore: Update v8 snapshot cache - windows #32998

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4ed6a15
chore: updating v8 snapshot cache
Nov 22, 2025
edd8a19
index on develop: b9401a60f2 chore: Check branch for latest chrome ve…
Nov 23, 2025
074f928
WIP on develop: b9401a60f2 chore: Check branch for latest chrome vers…
Nov 23, 2025
30c85fd
Merge commit 'stash' into update-v8-snapshot-cache-on-develop-windows
Nov 23, 2025
2c61c5f
index on develop: b9401a60f2 chore: Check branch for latest chrome ve…
Nov 24, 2025
cce8bc2
WIP on develop: b9401a60f2 chore: Check branch for latest chrome vers…
Nov 24, 2025
c9b6837
Merge commit 'stash' into update-v8-snapshot-cache-on-develop-windows
Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tooling/v8-snapshot/cache/win32/snapshot-meta.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4359,5 +4359,5 @@
"./tooling/v8-snapshot/cache/win32/snapshot-entry.js"
],
"deferredHashFile": "yarn.lock",
"deferredHash": "e687b38af49b78363a8f9ecc0de4199d8f2e8f616c8e5c58f4b75fe2e3446e65"
"deferredHash": "5a2412306b98e7753f91a9062a00f7326950dba66f0698527ed54b0d3d237da2"
Copy link

@cursor cursor bot Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Inconsistent snapshot cache hashes across platforms

The Windows snapshot cache hash is being updated to a different value than the darwin and linux caches. Since all three platform caches reference the same yarn.lock file via deferredHashFile, they should have identical deferredHash values. The darwin and linux caches both have hash 30957eb11212e6ebe537d8580a493219e1625eb6a65e3962e93b8dbe9e6d9e1c, but this change sets the Windows cache to 5a2412306b98e7753f91a9062a00f7326950dba66f0698527ed54b0d3d237da2. This inconsistency means the snapshot caches are out of sync across platforms, potentially causing different snapshot regeneration behavior and runtime inconsistencies.

Fix in Cursor Fix in Web

Copy link

@cursor cursor bot Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Inconsistent snapshot cache hashes across platforms

The Windows snapshot cache hash is being updated to a different value than the darwin and linux caches. Since all three platform caches reference the same yarn.lock file via deferredHashFile, they should have identical deferredHash values. The darwin and linux caches both have hash 30957eb11212e6ebe537d8580a493219e1625eb6a65e3962e93b8dbe9e6d9e1c, but this change sets the Windows cache to 5a2412306b98e7753f91a9062a00f7326950dba66f0698527ed54b0d3d237da2. This inconsistency means the snapshot caches are out of sync across platforms, potentially causing different snapshot regeneration behavior and runtime inconsistencies.

Fix in Cursor Fix in Web

}