Skip to content

chore: improve cloud api response logging #32773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 31, 2025
Merged

chore: improve cloud api response logging #32773

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8d88dcd
chore: improve cloud api response logging
cacieprins Oct 20, 2025
61c7b9e
review
cacieprins Oct 20, 2025
bdb2602
Merge branch 'develop' into less-verbose-response-logging
cacieprins Oct 20, 2025
ccec2f6
Merge branch 'develop' into less-verbose-response-logging
cacieprins Oct 24, 2025
5e61716
Merge branch 'develop' into less-verbose-response-logging
cacieprins Oct 28, 2025
f576781
Merge branch 'develop' into less-verbose-response-logging
cacieprins Oct 28, 2025
9f6131d
Merge branch 'develop' into less-verbose-response-logging
cacieprins Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/server/lib/cloud/api/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ import { isNonRetriableCertErrorCode } from '../network/non_retriable_cert_error

const debug = debugModule('cypress:server:cloud:api')
const debugProtocol = debugModule('cypress:server:protocol')
const debugVerbose = debugModule('cypress-verbose:server:cloud:api')

const THIRTY_SECONDS = humanInterval('30 seconds')
const SIXTY_SECONDS = humanInterval('60 seconds')
Expand Down Expand Up @@ -164,7 +165,9 @@ const rp = request.defaults((params: CypressRequestOptions, callback) => {
cacheResponse(resp, params)
}

return debug('response %o', resp)
debug(`${params.method} ${params.url}: ${resp ? `${resp.status} ${resp.statusText}` : 'empty response'}`)
Copy link

@cursor cursor bot Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Incorrect Response Property Access

The debug statement attempts to log resp.status and resp.statusText. The request-promise library uses statusCode and statusMessage for response properties. Also, resolveWithFullResponse isn't enabled, so resp often contains only the response body. This results in undefined values being logged instead of the actual HTTP status.

Fix in Cursor Fix in Web

debugVerbose('response headers: %o', resp ? resp.headers : 'no headers')
debugVerbose('body:', resp ? resp.body : 'no body')
})
})

Expand Down
Loading