Skip to content

Conversation

estrada9166
Copy link
Member

@estrada9166 estrada9166 commented Oct 6, 2025

Additional details

Steps to test

How has the user experience changed?

PR Tasks


Note

Adds a user preference and toggle to show/hide HTTP (fetch) request logs, wired through GraphQL/local settings, runner events, reporter, and tests.

  • Reporter/UI:
    • Add "Show HTTP requests" toggle in runnable options; clicking emits save:state.
    • Reporter accepts showFetchRequests and initializes app state; Command hides request commands when disabled.
  • State & Events:
    • Extend AppState with observable showFetchRequests plus setters/toggler; include in save:state and set on reporter:start.
    • Initialize/persist via usePreferences and localSettings.preferences.
  • GraphQL/Types:
    • Add showFetchRequests to LocalSettingsPreferences in gql-LocalSettings.ts and schema.graphql.
    • Update types: ReporterStartInfo, RunState, and preferences (defaultPreferences, allowedKeys).
  • App Integration:
    • Pass showFetchRequests through Vue runners (SpecRunnerOpenMode.vue, event-manager.ts, reporter.ts), stores, and mocks.
  • Tests:
    • Add/extend e2e and unit tests for the toggle, event payloads, and app state setters.

Written by Cursor Bugbot for commit b4e22b5. This will update automatically on new commits. Configure here.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Copy link

cypress bot commented Oct 6, 2025

cypress    Run #66228

Run Properties:  status check failed Failed #66228  •  git commit b4e22b517c: Merge branch 'develop' into alejandro/chore/hide-fetch-requests
Project cypress
Branch Review alejandro/chore/hide-fetch-requests
Run status status check failed Failed #66228
Run duration 20m 28s
Commit git commit b4e22b517c: Merge branch 'develop' into alejandro/chore/hide-fetch-requests
Committer Alejandro Estrada
View all properties for this run ↗︎

Test results
Tests that failed  Failures 3
Tests that were flaky  Flaky 12
Tests that did not run due to a developer annotating a test with .skip  Pending 1102
Tests that did not run due to a failure in a mocha hook  Skipped 4
Tests that passed  Passing 26688
View all changes introduced in this branch ↗︎

Warning

Partial Report: The results for the Application Quality reports may be incomplete.

UI Coverage  45.24%
  Untested elements 185  
  Tested elements 157  
Accessibility  97.95%
  Failed rules  4 critical   8 serious   2 moderate   2 minor
  Failed elements 101  

Tests for review

Failed  cypress/e2e/unit/events.cy.ts • 1 failed test • reporter

View Output

Test Artifacts
events > from runner > sets showFetchRequests on the app state on reporter:start Test Replay Screenshots
Failed  src/components/Blank.cy.tsx • 1 failed test • app-ct

View Output

Test Artifacts
An uncaught error was detected outside of a test Test Replay
Failed  cypress/e2e/studio/studio.cy.ts • 1 failed test • app-e2e

View Output

Test Artifacts
Cypress Studio > creates a new test from an empty spec Test Replay Screenshots
Flakiness  e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary Test Replay
Flakiness  issues/28527.cy.ts • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
issue 28527 > fails and then retries and verifies about:blank is not displayed Test Replay Screenshots
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox

View Output

Test Artifacts
... > stops waiting when an xhr request is canceled
    </td>
  </tr></table>
Flakiness  commands/files.cy.js • 1 flaky test • 5x-driver-firefox

View Output

Test Artifacts
src/cy/commands/files > #readFile > retries to read when ENOENT
    </td>
  </tr></table>
Flakiness  issues/28527.cy.ts • 1 flaky test • 5x-driver-firefox

View Output

Test Artifacts
issue 28527 > fails and then retries and verifies about:blank is not displayed Screenshots

The first 5 flaky specs are shown, see all 12 specs in Cypress Cloud.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: UI Pref Not Applied on Reporter Start

The reporter:start event handler is missing a call to initialize appState.showFetchRequests from the startInfo payload. This prevents the showFetchRequests preference from being applied when the reporter starts, so the UI won't reflect the saved preference.

packages/reporter/cypress/e2e/unit/events.cy.ts#L204-L208

it('sets showFetchRequests on the app state on reporter:start', () => {
runner.on.withArgs('reporter:start').callArgWith(1, { showFetchRequests: false })
expect(appState.setShowFetchRequests).to.have.been.calledWith(false)
})

packages/reporter/src/lib/events.ts#L107-L115

}))
runner.on('test:set:state', action('test:set:state', (props: UpdatableTestProps, cb: UpdateTestCallback) => {
runnablesStore.updateTest(props, cb)
}))
runner.on('paused', action('paused', (nextCommandName: string) => {
appState.pause(nextCommandName)
statsStore.pause()

packages/reporter/src/lib/events.ts#L132-L140

}))
localBus.on('resume', action('resume', () => {
appState.resume()
statsStore.resume()
runner.emit('runner:resume')
}))
localBus.on('next', action('next', () => {

Fix in Cursor Fix in Web



if (model.name === 'request' && !appState.showFetchRequests) {
return null
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Fetch Request Filtering Excludes Non-'Request' Commands

The command filtering intended to hide fetch requests only applies to commands named 'request'. This causes commands from cy.intercept(), which have different names, to remain visible even when fetch requests are hidden.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant