Skip to content

Conversation

AtofStryker
Copy link
Contributor

@AtofStryker AtofStryker commented Oct 3, 2025

  • Closes

Additional details

Converts @packages/icons to use vitest and removes the ts-node entrypoint making ESM possible. The tests before weren't actually being run in CI. This adds the icons package to the test script so the tests are now executed

Steps to test

How has the user experience changed?

PR Tasks


Note

Compiles @packages/icons with CJS/ESM entrypoints, migrates tests to Vitest, and adds the package to the root test run while updating related configs/docs.

  • @packages/icons:
    • Build/Outputs: Add dual builds with index.js (CJS) and index.mjs (ESM); introduce tsconfig.cjs.json/tsconfig.esm.json and shared tsconfig.base.json; update package.json scripts (build, build-assets, build:cjs, build:esm) and fields (module, types); use tsx for build scripts; adjust dist path in index.ts.
    • Testing: Replace Mocha/Chai with Vitest (vitest.config.ts, new test/icons.spec.ts), remove old test/icons_spec.ts; switch test-unit to vitest run; add ignore rules for built artifacts.
  • Repo/Docs:
    • Root tests: Include @packages/icons in top-level test script.
    • Guide: Update guides/esm-migration.md to mark packages/icons as completed and tidy https-proxy entries.

Written by Cursor Bugbot for commit 549af08. This will update automatically on new commits. Configure here.

@AtofStryker AtofStryker self-assigned this Oct 3, 2025
@AtofStryker AtofStryker changed the title Chore/icons vitest chore: convert icons to a compiled package and convert tests to vitest Oct 3, 2025
Copy link

cypress bot commented Oct 3, 2025

cypress    Run #66213

Run Properties:  status check passed Passed #66213  •  git commit 3cf811e60c: correctly configure ES Module for packages/icons
Project cypress
Branch Review chore/icons_vitest
Run status status check passed Passed #66213
Run duration 10m 53s
Commit git commit 3cf811e60c: correctly configure ES Module for packages/icons
Committer Bill Glesias
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 3
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 857
View all changes introduced in this branch ↗︎
UI Coverage  45.7%
  Untested elements 137  
  Tested elements 117  
Accessibility  97.36%
  Failed rules  3 critical   7 serious   2 moderate   1 minor
  Failed elements 77  

@AtofStryker AtofStryker changed the title chore: convert icons to a compiled package and convert tests to vitest chore: convert @packages/icons to a compiled package and convert tests to vitest Oct 6, 2025
cursor[bot]

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants