Test contrib (do not review, do not merge) #32642
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cleci config pack to compose them into the main workflows.yml file
…ck off pull-request workflow after approval
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| - test-kitchensink: | ||
| requires: | ||
| - build | ||
| - approve-contributor-pr |
There was a problem hiding this comment.
Bug: CI Pipeline Blocked by Branch Filter
The approve-contributor-pr job is filtered to run only for branches matching pull/[0-9]+/. This creates a dependency deadlock for internal PRs, as many critical jobs now require approve-contributor-pr. For internal PRs, this approval job never starts, blocking all dependent jobs and preventing the full CI pipeline from executing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?Note
Refactors CircleCI to gate external PRs behind an approval step and remove the contributor-specific workflow, auto-detects contributor PRs during build, bumps the cache version, and tidies type definitions.
linux-x64-contributorworkflow by enhancingworkflows/pull-request.ymlwith anapprove-contributor-prgate and adding it as a requirement to downstream jobs; move finalization jobs (percy-finalize,verify-accessibility-results) to a dedicated section.--is-contributor-prfrom<< pipeline.git.branch >>instead of passing abuild.is_contributor_prparameter..circleci/cache-version.txtto invalidate caches.cli/types/cypress.d.tscleanups (string literal/style tweaks, whitespace) with no functional API changes.Written by Cursor Bugbot for commit ea3703b. This will update automatically on new commits. Configure here.