chore: make the @packages/telemetry an independent bundle
#32623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
chore/bundle_telemetry
|
| Run status |
|
| Run duration | 19m 54s |
| Commit |
|
| Committer | Bill Glesias |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
12
|
Pending
|
1102
|
Skipped
|
4
|
Passing
|
26706
|
| View all changes introduced in this branch ↗︎ | |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
45.4%
|
|
|---|---|
|
Untested elements
|
185
|
|
Tested elements
|
158
|
Accessibility
97.97%
|
|
|---|---|
|
Failed rules
|
4 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
101
|
Tests for review
cypress/e2e/studio/studio.cy.ts • 1 failed test • app-e2e
| Test | Artifacts | |
|---|---|---|
| Cypress Studio > updates an existing test with assertions |
Test Replay
Screenshots
|
|
issues/28527.cy.ts • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| issue 28527 > fails and then retries and verifies about:blank is not displayed |
Test Replay
Screenshots
|
|
e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary |
Test Replay
|
|
issues/28527.cy.ts • 1 flaky test • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| issue 28527 > fails and then retries and verifies about:blank is not displayed |
Test Replay
Screenshots
|
|
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox
| Test | Artifacts | |||||||
|---|---|---|---|---|---|---|---|---|
| ... > stops waiting when an xhr request is canceled |
| |||||||
| Test | Artifacts | |
|---|---|---|
| ... > errors > throws when waiting for response to route |
Test Replay
|
|
The first 5 flaky specs are shown, see all 11 specs in Cypress Cloud.
AtofStryker
changed the title
@packages/telemetry an independent bundle
AtofStryker
force-pushed
the
chore/bundle_telemetry
branch
from
611d915 to
5262613
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
AtofStryker
force-pushed
the
chore/bundle_telemetry
branch
from
5262613 to
74cc257
Compare
…ded ts-node to register entrypoint. Both ESM and CJS distributions are built and types are used as source to be compatible with older styles of commonjs bundling. Types are not shipped with the package.
AtofStryker
force-pushed
the
chore/bundle_telemetry
branch
from
74cc257 to
98981fa
Compare
AtofStryker
changed the title
@packages/telemetry an independent bundle @packages/telemetry an independent bundle
cacieprins
approved these changes
Oct 10, 2025
AtofStryker
commented
Oct 10, 2025
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Makes
@packages/telemetryan independent bundle. This change, similar to #32633, builds@packages/telemetrywith 3 entry points:browserdirectory.We are somewhat limited with an older
moduleResolutionand can't leverage exports similar to the CLI, the best we can do is userollupto move/rename the compiled browser bundle (NOTE:node_modulesdependencies are external and will be resolved by the package) to have abrowserentry point, and omit theclientfile in thenodebuild.We bundle delcarations with the code so we don't have to worry about type checking the telemetry package in other extraneous monorepo packages as we are no longer importing from source
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?Note
Bundles @packages/telemetry as an independent CJS/ESM/browser package and switches browser consumers to
@packages/telemetry/browser/client, with minor proxy fix and docs/tests updates.rollup.config.mjs) and split outputs:cjs/,esm/,browser/with new tsconfigs (tsconfig.cjs.json,tsconfig.esm.json,tsconfig.browser.json).package.jsonfields (main→cjs/node.js, addmodule,types,files) and scripts to build CJS/ESM/Browser; add dev deps (rollup, plugin-typescript, typescript, rimraf).src/telemetry/*; update imports insrc/client.tsandsrc/node.ts; improveTelemetryNooptypings; remove legacyindex.jsand old tsconfig.@packages/telemetry/browser/clientinpackages/appandpackages/driver.span || undefinedtohandleHttpRequest.guides/esm-migration.md.isVerbose), fixing types.yarn.lock.Written by Cursor Bugbot for commit e15f512. This will update automatically on new commits. Configure here.