internal: (studio) support creating new test in root suite by mschile · Pull Request #32024 · cypress-io/cypress

mschile · 2025-07-15T14:19:22Z

Related: https://github.com/cypress-io/cypress-services/issues/11097

Additional details

When creating a new test, instead of reruning and entering Studio mode, we now set Studio to active, which causes the panel to be displayed but all of the tests are still displayed.
Instead of driving off the suiteId, we now look for the newTestLineNumber in the url. When found, we find the test that also starts on that line and call setOnlyTestId with the appropriate id.

Steps to test

Checkout the mschile/studio/new_test_root_suite services branch
Open up the Studio side panel and add a new test
Verify the new test is correctly added to the spec and we correctly re-enter Studio mode when the test is created.

How has the user experience changed?

PR Tasks

Have tests been added/updated?
[n/a] Has a PR for user-facing changes been opened in cypress-documentation?
[n/a] Have API changes been updated in the type definitions?

Copilot

Pull Request Overview

This PR adds support for creating a new test in the root suite by tracking a newTestLineNumber instead of driving off suiteId, updates the runner normalization logic, and adjusts the Studio store and event flows to enter Studio mode without rerunning for new tests.

Runner now sets onlyTestId based on newTestLineNumber and removes createEmptyOnlyTest.
Studio store tracks newTestLineNumber, updates URL parameters, and introduces setActive(isActive) to control panel visibility.
Event manager and aut-iframe entry points are updated to avoid unnecessary reruns when starting Studio for a new test.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
packages/driver/src/cypress/runner.ts	Handle `newTestLineNumber` in `normalizeAll`/`normalize` and drop `createEmptyOnlyTest`.
packages/app/src/store/studio-store.ts	Add `newTestLineNumber` state, update URL param logic, and rename `setInactive` to `setActive`.
packages/app/src/runner/event-manager.ts	Replace legacy `studioInit` (rerun) with `setActive(true)` for new-test flows.
packages/app/src/runner/aut-iframe.ts	Always call `studioStore.start` in `startStudio`, removing the loading check.

Comments suppressed due to low confidence (3)

packages/app/src/store/studio-store.ts:168

setSuiteId does not clear newTestLineNumber or include it in the URL parameters, which may leave stale line-number state when switching suites; consider resetting newTestLineNumber and updating the URL filter here.

      this._updateUrlParams(['testId', 'suiteId'])

packages/driver/src/cypress/runner.ts:789

This new branch handling newTestLineNumber should be covered by unit tests to verify that onlyTestId is correctly set when the line numbers match.

  if (getNewTestLineNumber() && runnable.invocationDetails?.line === getNewTestLineNumber()) {

packages/app/src/store/studio-store.ts:209

[nitpick] The method name setActive may be ambiguous for a boolean setter; consider renaming to setIsActive for clearer intent.

    setActive (isActive: boolean) {

packages/app/src/store/studio-store.ts

cypress · 2025-07-15T16:18:55Z

cypress Run #63865

Run Properties: Passed #63865 • b6eb1d4a07: fixing tests

Project	`cypress`
Branch Review	`mschile/studio/new_test_root_suite_2`
Run status	`Passed #63865`
Run duration	`11m 25s`
Commit	`b6eb1d4a07: fixing tests`
Committer	`Matthew Schile`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`0`
Pending	`0`
Skipped	`0`
Passing	`692`
View all changes introduced in this branch ↗︎

UI Coverage `37.91%`
Untested elements	`131`
Tested elements	`80`

Accessibility `97.42%`
Failed rules	`3 critical` `7 serious` `1 moderate` `1 minor`
Failed elements	`62`

mabela416 · 2025-07-16T14:25:12Z

packages/app/src/store/studio-store.ts

+        getCypress().runner.setNewTestLineNumber(this.newTestLineNumber)
+      } else {
+        if (this.suiteId) {
+          getCypress().runner.setOnlySuiteId(this.suiteId)


I think this can be removed. It doesn't look like we're doing anything anymore when we set setOnlySuiteId

removed 0762b70

mabela416

The page is not reloading for the test I just created and then if I exit out of the specs list and go back in, only the test i just created is loaded instead of all the tests in the spec

Screen.Recording.2025-07-16.at.10.49.36.AM.mov

mschile · 2025-07-16T15:00:29Z

The page is not reloading for the test I just created and then if I exit out of the specs list and go back in, only the test i just created is loaded instead of all the tests in the spec

Screen.Recording.2025-07-16.at.10.49.36.AM.mov

@mabela416, are you sure you're running all the correct code? I just tried and it worked for me.

Screen.Recording.2025-07-16.at.8.58.35.AM.mov

mabela416 · 2025-07-16T16:06:09Z

Yeah I double checked that I was on both branches for cypress-services and cypress and I rebuilt everything.
Also, I don't think the studio wand and the "create new" test controls should not be available when studio is open

mabela416 · 2025-07-16T16:11:31Z

I changed to another project and it worked but i'm not sure why it didn't work on my other project

mschile · 2025-07-16T16:12:20Z

I changed to another project and it worked but i'm not sure why it didn't work on my other project

Do you have watchForFileChanges set to false on the other project?

mabela416 · 2025-07-16T16:23:18Z

I changed to another project and it worked but i'm not sure why it didn't work on my other project

Do you have watchForFileChanges set to false on the other project?

I did! but it should work even if watchForFileChanges is set to false right?

mschile · 2025-07-16T16:24:24Z

Yes, it should, I'll have to look into it.

mschile · 2025-07-16T18:40:01Z

I changed to another project and it worked but i'm not sure why it didn't work on my other project

Do you have watchForFileChanges set to false on the other project?

I did! but it should work even if watchForFileChanges is set to false right?

This has been fixed.

mschile · 2025-07-16T19:27:05Z

Also, I don't think the studio wand and the "create new" test controls should not be available when studio is open

I actually like the controls being available since someone might open the panel and then want to go to a specific test or change the suite.

mabela416 · 2025-07-16T19:34:51Z

Also, I don't think the studio wand and the "create new" test controls should not be available when studio is open

I actually like the controls being available since someone might open the panel and then want to go to a specific test or change the suite.

can you check with @emilmilanov and @jennifer-shehane because the figma does not have them and I think there were other controls that they wanted to add in the future

mschile · 2025-07-16T19:51:32Z

Hmm, I see the New Test here and this design seems to elude to allowing the user to select a test from the list.

Regardless, I think it makes sense to merge this PR with the current behavior and then we can make changes if needed.

…new test in root suite (#32024)

…w test in root suite (#32024)

…new test in root suite (#32024)

…w test in root suite (#32024)

…new test in root suite (#32024)

…w test in root suite (#32024)

* chore: updating v8 snapshot cache * index on release/15.0.0: 47bda54 fix: remove 'new' badge from Create from Component, fix parsing (#31457) * index on release/15.0.0: 3b88383 internal: (studio) support creating new test in root suite (#32024) --------- Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>

cypress-bot · 2025-08-20T17:49:19Z

Released in 15.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v15.0.0, please open a new issue.

mschile added 4 commits July 14, 2025 22:05

add newTestLineNumber

7750bc9

updates

6628951

adding comment

a74549c

fixes

84a8e0c

mschile requested a review from Copilot July 15, 2025 14:19

Merge branch 'release/15.0.0' into mschile/studio/new_test_root_suite_2

9ebc601

Copilot AI reviewed Jul 15, 2025

View reviewed changes

packages/app/src/store/studio-store.ts Show resolved Hide resolved

mschile requested review from astone123 and mabela416 July 15, 2025 14:22

test update

4b8b3c9

This comment was marked as outdated.

Sign in to view

astone123 approved these changes Jul 15, 2025

View reviewed changes

mabela416 reviewed Jul 16, 2025

View reviewed changes

mabela416 requested changes Jul 16, 2025

View reviewed changes

test updates

6184771

mschile self-assigned this Jul 16, 2025

mabela416 approved these changes Jul 16, 2025

View reviewed changes

pr updates

0762b70

This comment was marked as outdated.

Sign in to view

mschile added 2 commits July 16, 2025 15:10

Merge branch 'release/15.0.0' into mschile/studio/new_test_root_suite_2

5bf33fc

fixing test

7b7da2e

This comment was marked as outdated.

Sign in to view

fixing test

833ba9a

This comment was marked as outdated.

Sign in to view

fixing tests

b6eb1d4

This comment was marked as outdated.

Sign in to view

mschile merged commit 3b88383 into release/15.0.0 Jul 17, 2025
83 of 87 checks passed

mschile deleted the mschile/studio/new_test_root_suite_2 branch July 17, 2025 03:38

cypress-app-bot pushed a commit that referenced this pull request Jul 17, 2025

index on release/15.0.0: 3b88383 internal: (studio) support creating …

2d12640

…new test in root suite (#32024)

cypress-app-bot pushed a commit that referenced this pull request Jul 17, 2025

WIP on release/15.0.0: 3b88383 internal: (studio) support creating ne…

ecc6cbd

…w test in root suite (#32024)

cypress-app-bot pushed a commit that referenced this pull request Jul 17, 2025

index on release/15.0.0: 3b88383 internal: (studio) support creating …

9e09db2

…new test in root suite (#32024)

cypress-app-bot pushed a commit that referenced this pull request Jul 17, 2025

WIP on release/15.0.0: 3b88383 internal: (studio) support creating ne…

674908a

…w test in root suite (#32024)

cypress-app-bot pushed a commit that referenced this pull request Jul 17, 2025

index on release/15.0.0: 3b88383 internal: (studio) support creating …

99dbd1f

…new test in root suite (#32024)

cypress-app-bot pushed a commit that referenced this pull request Jul 17, 2025

WIP on release/15.0.0: 3b88383 internal: (studio) support creating ne…

413125a

…w test in root suite (#32024)

cypress-bot bot locked as resolved and limited conversation to collaborators Aug 20, 2025

Comments

Conversation

mschile commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Additional details

Steps to test

How has the user experience changed?

PR Tasks

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

cypress bot commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

cypress Run #63865

Uh oh!

This comment was marked as outdated.

Uh oh!

mabela416 Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

mschile Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

mabela416 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mschile commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mabela416 commented Jul 16, 2025

Uh oh!

mabela416 commented Jul 16, 2025

Uh oh!

mschile commented Jul 16, 2025

Uh oh!

mabela416 commented Jul 16, 2025

Uh oh!

mschile commented Jul 16, 2025

Uh oh!

mschile commented Jul 16, 2025

Uh oh!

mschile commented Jul 16, 2025

Uh oh!

mabela416 commented Jul 16, 2025

Uh oh!

mschile commented Jul 16, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

cypress-bot bot commented Aug 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mschile commented Jul 15, 2025 •

edited

Loading

cypress bot commented Jul 15, 2025 •

edited

Loading

mabela416 left a comment •

edited

Loading

mschile commented Jul 16, 2025 •

edited

Loading