Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable nx caching and add web extension docs #30449

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

AtofStryker
Copy link
Contributor

  • Closes N/A

Additional details

This PR has two chores

  • disables the nx cache. With the current state of our monorepo, it is too difficult to deterministically bust the cache. Because of this, we are electing to disable the nx cache for linting, typechecking, and building packages so we are alerted when issues are introduced that might not be directly related to the code changes present.
  • Adds docs on the web extension. I noticed the firefox section of the web extension debugging was not written, so I added some docs and updated the chrome docs on debugging the web extension

Steps to test

How has the user experience changed?

PR Tasks

@@ -5,25 +5,26 @@
"default",
"{workspaceRoot}/.eslintrc.js"
],
"cache": true
"cache": false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to log an issue to strip out nx entirely? Or are we keeping it around for the output?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. Since lerna is now owned by nx, the integration is pretty tight. I think it's easiest to likely just disable caching as it does some other things that are beneficial

@AtofStryker AtofStryker merged commit c8439b2 into develop Oct 23, 2024
80 of 85 checks passed
@AtofStryker AtofStryker deleted the chore/disable_nx_caching branch October 23, 2024 21:36
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 24, 2024

Released in 13.15.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.15.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants