Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump semantic-release-monorepo to v8 to be able to handle esm #30107

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

AtofStryker
Copy link
Contributor

@AtofStryker AtofStryker commented Aug 26, 2024

  • Closes N/A

Additional details

Accidentally broke the verify-release-readiness job on develop when merging #30087. I tested this locally but I obviously missed something. The break was semantic-release-monorepo not supporting ESM, which was added in v8.

Steps to test

SSHed into the failing develop job, updated the dependency, and reran the task in the container. Everything is passing as expected.

How has the user experience changed?

PR Tasks

@AtofStryker AtofStryker force-pushed the chore/update_semantic_release_monorepo branch from f7f0f85 to 2624aac Compare August 26, 2024 16:04
@AtofStryker AtofStryker self-assigned this Aug 26, 2024
Copy link

cypress bot commented Aug 26, 2024

cypress    Run #56806

Run Properties:  status check passed Passed #56806  •  git commit 2624aac7a9: chore: bump semantic-release-monorepo to v8 to be able to handle esm [run ci].
Project cypress
Branch Review chore/update_semantic_release_monorepo
Run status status check passed Passed #56806
Run duration 17m 35s
Commit git commit 2624aac7a9: chore: bump semantic-release-monorepo to v8 to be able to handle esm [run ci].
Committer AtofStryker
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 77
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5589
View all changes introduced in this branch ↗︎
UI Coverage  null%
  Untested elements 0  
  Tested elements 0  
Accessibility  null%
  Failed rules  0 critical   0 serious   0 moderate   0 minor
  Failed elements 0  

@AtofStryker AtofStryker merged commit 3bf0199 into develop Aug 26, 2024
83 of 85 checks passed
@AtofStryker AtofStryker deleted the chore/update_semantic_release_monorepo branch August 26, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants