Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update semantic release to v22 #30087

Merged
merged 2 commits into from
Aug 26, 2024
Merged

chore: update semantic release to v22 #30087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e64d330
chore: update semantic-release from 19 to 22 to see what fails [run ci]
AtofStryker Aug 22, 2024
ada1bcc
fix npm internal exit code test [run ci]
AtofStryker Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion npm/puppeteer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"express": "4.19.2",
"mocha": "^9.2.2",
"rimraf": "^5.0.1",
"semantic-release": "19.0.3",
"semantic-release": "22.0.12",
"sinon": "^13.0.1",
"sinon-chai": "^3.7.0",
"ts-node": "^10.9.2",
Expand Down
2 changes: 1 addition & 1 deletion npm/webpack-preprocessor/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"mocha": "^7.1.0",
"mockery": "2.1.0",
"proxyquire": "2.1.3",
"semantic-release": "19.0.3",
"semantic-release": "22.0.12",
"sinon": "^9.0.0",
"sinon-chai": "^3.5.0",
"snap-shot-it": "7.9.2",
Expand Down
5 changes: 2 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
"@octokit/auth-app": "6.0.3",
"@octokit/core": "5.0.2",
"@percy/cli": "1.27.4",
"@semantic-release/changelog": "5.0.1",
"@semantic-release/changelog": "6.0.3",
"@semantic-release/git": "10.0.1",
"@types/better-sqlite3": "^7.6.3",
"@types/bluebird": "3.5.29",
Expand Down Expand Up @@ -189,7 +189,7 @@
"print-arch": "1.0.0",
"proxyquire": "2.1.3",
"rimraf": "3.0.2",
"semantic-release": "19.0.3",
"semantic-release": "22.0.12",
"semantic-release-monorepo": "7.0.3",
"semver": "7.5.3",
"shelljs": "0.8.5",
Expand Down Expand Up @@ -265,7 +265,6 @@
"**/@types/enzyme": "3.10.5",
"**/@types/react": "16.9.50",
"**/jquery": "3.4.1",
"**/nx-cloud/**/tar": "6.1.15",
"**/pretty-format": "26.4.0",
"**/sharp": "0.29.3",
"**/socket.io-parser": "4.0.5",
Expand Down
4 changes: 2 additions & 2 deletions packages/server/test/integration/cli_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,14 +99,14 @@ describe('CLI Interface', () => {
/**
* In certain versions of npm, code with an exit code of 10 (Internal Runtime Javascript Failure)
* is ultimately displayed as an exit code of 1 (Uncaught Runtime Exception).
* This seems to occur before Node 7 / NPM 4 and after Node 14/ NPM 7.
* This seems to occur before Node 7 / NPM 4 and between Node 14/ NPM 7 and Node 16 / NPM 8.
* Please see https://github.com/arzzen/all-exit-error-codes/blob/master/programming-languages/javascript/nodejs.md
* for more details.
*
* @returns {boolean}
*/
const doesNpmObscureInternalExitCode = () => {
return semver.lt(npmVersion, '4.0.0') || semver.gt(npmVersion, '6.0.0')
return semver.lt(npmVersion, '4.0.0') || (semver.gt(npmVersion, '6.0.0') && semver.lt(npmVersion, '8.0.0'))
}

beforeEach(() => {
Expand Down
Loading
Loading