Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: increase electron node version print timeout to pass binary jo… #29859

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

AtofStryker
Copy link
Contributor

…bs on darwin x64

  • Closes

Additional details

Currently the darwin x64 jobs are timing out to build the binary when trying to retrieve the electron node version. This PR increases that timeout from 5 seconds to 10 seconds.

I have verified that 10 seconds works when logged into the circle mac runner and this should unblock the rest of the package binary job for darwin x64

Steps to test

How has the user experience changed?

PR Tasks

@AtofStryker AtofStryker force-pushed the chore/increase_electron_timeout branch from 619f01a to 673b715 Compare July 15, 2024 18:35
@jennifer-shehane jennifer-shehane self-requested a review July 15, 2024 19:12
Copy link

cypress bot commented Jul 15, 2024

6 flaky tests on run #56151 ↗︎

0 29307 1328 0 Flakiness 6

Details:

chore: increase electron node version print timeout to pass binary jobs on darwi...
Project: cypress Commit: 673b715e41
Status: Passed Duration: 23:50 💡
Started: Jul 15, 2024 6:56 PM Ended: Jul 15, 2024 7:20 PM
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-chrome

View Output

Test Artifacts
network stubbing > waiting and aliasing > yields the expected interception when two requests are raced Test Replay
Flakiness  e2e/origin/navigation.cy.ts • 1 flaky test • 5x-driver-chrome

View Output

Test Artifacts
delayed navigation > errors > redirects to an unexpected cross-origin and calls another command in the cy.origin command Test Replay
Flakiness  e2e/origin/commands/waiting.cy.ts • 1 flaky test • 5x-driver-chrome

View Output

Test Artifacts
... > throws when foo cannot resolve Test Replay
Flakiness  commands/net_stubbing.cy.ts • 3 flaky tests • 5x-driver-webkit

View Output

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse
    </td>
  </tr>
  <tr>
    <td colspan="2">
      <a href="https://cloud.cypress.io/projects/ypt4pf/runs/56151/overview/a0522b36-2cd0-4734-ba21-d654e71d8793?reviewViewBy=FLAKY&utm_source=github&utm_medium=flaky&utm_campaign=view%20test">
        ... > with `resourceType` > can match a proxied image request by resourceType
      </a>
    </td>
    <td>
      
    </td>
  </tr>
  <tr>
    <td colspan="2">
      <a href="https://cloud.cypress.io/projects/ypt4pf/runs/56151/overview/5809678c-b25b-4c1e-adc0-e28e60df67fa?reviewViewBy=FLAKY&utm_source=github&utm_medium=flaky&utm_campaign=view%20test">
        ... > stops waiting when an xhr request is canceled
      </a>
    </td>
    <td>
      
    </td>
  </tr></table>

Review all test suite changes for PR #29859 ↗︎

@AtofStryker AtofStryker merged commit 217f27f into develop Jul 15, 2024
103 of 109 checks passed
@AtofStryker AtofStryker deleted the chore/increase_electron_timeout branch July 15, 2024 19:59
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 16, 2024

Released in 13.13.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.13.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jul 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants