Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix testing kitchen sink job against staging as it needs node 20.8 or greater #29771

Merged
merged 1 commit into from
Jun 28, 2024
Merged

chore: fix testing kitchen sink job against staging as it needs node 20.8 or greater #29771

merged 1 commit into from
Jun 28, 2024

Conversation

AtofStryker
Copy link
Contributor

@AtofStryker AtofStryker commented Jun 28, 2024 •
edited
Loading

  • Closes N/A

Additional details

Fixes the test-kitchensink-against-staging job by upgrading the docker image to use node 20.15.0. Job is currently failing in develop due to inter dependency ( see https://app.circleci.com/pipelines/github/cypress-io/cypress/62616/workflows/ae52fcbf-60b7-427c-9fed-4fd926673549/jobs/2592519). see cypress-io/cypress-docker-images#1133 for image source code

Steps to test

How has the user experience changed?

PR Tasks

@AtofStryker AtofStryker mentioned this pull request Jun 28, 2024
Merged
@AtofStryker AtofStryker changed the title chore: fix testing kitchen sink job against staging as it needs node … chore: fix testing kitchen sink job against staging as it needs node 20.8 or greater Jun 28, 2024
@jennifer-shehane jennifer-shehane removed the request for review from cacieprins June 28, 2024 18:03
@AtofStryker AtofStryker force-pushed the chore/fix_kitchensink_against_staging_job branch from ee046ac to 0816264 Compare June 28, 2024 18:18
@cypress Cypress
Copy link

cypress bot commented Jun 28, 2024 •
edited
Loading

3 flaky tests on run #55976 ↗︎

0 10235 1028 0 Flakiness 3

Details:

chore: fix testing kitchen sink job against staging as it needs node 20.8 or gre...
Project: cypress Commit: 081626450d
Status: Passed Duration: 17:03 💡
Started: Jun 28, 2024 6:55 PM Ended: Jun 28, 2024 7:12 PM
Flakiness  cypress/e2e/commands/net_stubbing.cy.ts • 3 flaky tests • 5x-driver-webkit

View Output

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse 
    </td>
  </tr>
  <tr>
    <td colspan="2">
      <a href="https://cloud.cypress.io/projects/ypt4pf/runs/55976/overview/2e92f155-c1b0-40aa-9dbd-41a41cdb070b?reviewViewBy=FLAKY&utm_source=github&utm_medium=flaky&utm_campaign=view%20test">
        ... > with `resourceType` > can match a proxied image request by resourceType
      </a>
    </td>
    <td>
      
    </td>
  </tr>
  <tr>
    <td colspan="2">
      <a href="https://cloud.cypress.io/projects/ypt4pf/runs/55976/overview/64346cb1-799e-4ac2-b0ce-97246ee4b007?reviewViewBy=FLAKY&utm_source=github&utm_medium=flaky&utm_campaign=view%20test">
        ... > stops waiting when an xhr request is canceled
      </a>
    </td>
    <td>
      
    </td>
  </tr></table>

Review all test suite changes for PR #29771 ↗︎

@AtofStryker AtofStryker merged commit aa8aaa1 into develop Jun 28, 2024
90 of 92 checks passed
@AtofStryker AtofStryker deleted the chore/fix_kitchensink_against_staging_job branch June 28, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanthemanuel ryanthemanuel ryanthemanuel approved these changes

@jennifer-shehane jennifer-shehane jennifer-shehane approved these changes

Assignees

@AtofStryker AtofStryker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AtofStryker @jennifer-shehane @ryanthemanuel