chore: move questions-remain into cypress repo #29542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,39 @@ | |||
| const la = require('lazy-ass') | |||
There was a problem hiding this comment.
| @@ -0,0 +1,46 @@ | |||
| /* global sinon */ | |||
There was a problem hiding this comment.
| } | ||
|
|
||
| it('is a function', () => { | ||
| if (typeof questionsRemain !== 'function') throw new Error('questionsRemain is not a function') |
There was a problem hiding this comment.
I removed the is dep. 🤷🏻♀️
| } | ||
|
|
||
| // console.log(questionsRemain(propertiesToQuestions)(options)) | ||
| return questionsRemain(propertiesToQuestions)(options).then(snapshot) |
There was a problem hiding this comment.
These are promises, so chain .then with snapshot
| @@ -197,7 +196,7 @@ | |||
| "semver": "7.5.3", | |||
| "shelljs": "0.8.5", | |||
| "sinon": "7.3.2", | |||
| "snap-shot-it": "7.9.3", | |||
| "snap-shot-it": "7.9.10", | |||
There was a problem hiding this comment.
I was having issues with snapshot and though this would fix it. Seems like a good change even though it's not needed for this update.
10 flaky tests on run #55504 ↗︎
Details:
|
||||||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | ||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| basic login > visit primary first > logs in with idp redirect |
| ||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > stops waiting when an fetch request is canceled |
Test Replay
|
|
commands/querying/querying.cy.js • 1 flaky test • 5x-driver-chrome:beta
| Test | Artifacts | |
|---|---|---|
| ... > throws when alias property isnt a digit or `all` |
Test Replay
|
|
commands/waiting.cy.js • 2 flaky tests • 5x-driver-chrome:beta
| Test | Artifacts | |
|---|---|---|
| ... > errors > throws when route is never resolved |
Test Replay
|
|
| ... > errors > throws when waiting for 2nd response to route |
Test Replay
|
|
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| ... > stops waiting when an fetch request is canceled |
Test Replay
|
|
The first 5 flaky specs are shown, see all 7 specs in Cypress Cloud.
Review all test suite changes for PR #29542 ↗︎
mschile
approved these changes
May 24, 2024
ryanthemanuel
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
This moves the functionality of the https://github.com/cypress-io/questions-remain repo into the Cypress repo. It is only used for this repo within our company.
The repo is a single file, with a single test file. I think it's better managed within the main repo where all deps can be kept up to date together and no release motions are required outside of the repo. Additionally, outside users will not have an expectation to maintain this code for outside use.
I intend to archive the https://github.com/cypress-io/questions-remain repo once this is merged.
Steps to test
I moved a unit test over from the other repo. It was already a bit out of date tbh.
How has the user experience changed?
N/A - should be no change.
PR Tasks
cypress-documentation?type definitions?