fix: Vite dev server add searchForWorkspaceRoot

[radoslavirha]

• Closes Vite server not working in monorepo #26035 (comment)

Additional details

Because server.fs.allow is defined, I need to detect workspace root correctly.

https://vitejs.dev/config/server-options.html#server-fs-allow

Steps to test

Create monorepo with Vite app and test with Cypress.

How has the user experience changed?

PR Tasks

• Have tests been added/updated?
• Has a PR for user-facing changes been opened in cypress-documentation?
• Have API changes been updated in the type definitions?

[CLAassistant]

All committers have signed the CLA.

[cypress]

Passing run #44666 ↗︎

0

576

0

0

0

Details:

misc: Vite dev server add searchForWorkspaceRoot
Project: cypress	Commit: a09449acd3
Status: Passed	Duration: 07:16 💡
Started: Mar 10, 2023 12:24 AM	Ended: Mar 10, 2023 12:32 AM

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[lmiller1990]

Nice, thanks a lot! We will get one more ✅ and this can go in the next release.

[lmiller1990]

Hi, I realized this won't work as is, but can be fixed with a small change, see comment, thanks!

[lmiller1990]

Nice - @mike-plummer can you take a quick 👀 , too?

[mike-plummer]

LGTM, will merge this later today

[lmiller1990]

We've actually got a real failure now, we may need to rework one test: https://app.circleci.com/pipelines/github/cypress-io/cypress/50439/workflows/06809a66-8100-450e-a443-61812ef1d6d0/jobs/2094959/tests#failed-test-0

I think it's now detecting the vite version in the main monorepo, not the stale version the test is supposed to be detecting. I don't expect this will happen in production, it's a side effect of us running tests against the non-built Cypress binary.

Maybe someone internally can pick this up? I will try and take a look.

[lmiller1990]

Ahh, this API is new, we just need a null check. It's in v3 and v4.

[radoslavirha]

Thank you @lmiller1990 !

[lmiller1990]

Yep, pls wait around 2 weeks for the next release.