Skip to content

chore: update workflows.yml to include the v8 snapshot update branch #25784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Feb 14, 2023
Merged

chore: update workflows.yml to include the v8 snapshot update branch #25784

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
7939cf9
Update workflows.yml
ryanthemanuel Feb 13, 2023
322873a
Update update_v8_snapshot_cache.yml
ryanthemanuel Feb 13, 2023
4fcc2ef
Update workflows.yml
ryanthemanuel Feb 13, 2023
ab80654
Update update_v8_snapshot_cache.yml
ryanthemanuel Feb 13, 2023
659e9a6
Update update_v8_snapshot_cache.yml
ryanthemanuel Feb 13, 2023
b75f43a
Update .github/workflows/update_v8_snapshot_cache.yml
ryanthemanuel Feb 13, 2023
3ef8ad1
Update snapshot-meta.json
ryanthemanuel Feb 13, 2023
1ec336e
chore: updating v8 snapshot cache
Feb 13, 2023
aaf3b6d
Merge branch 'develop' into ryanthemanuel-patch-2
ryanthemanuel Feb 13, 2023
393f252
Update update-browser-versions.yml
ryanthemanuel Feb 13, 2023
ca7a4be
Update update_v8_snapshot_cache.yml
ryanthemanuel Feb 13, 2023
0144ba7
Merge branch 'develop' into ryanthemanuel-patch-2
ryanthemanuel Feb 13, 2023
8377085
Merge branch 'develop' into ryanthemanuel-patch-2
ryanthemanuel Feb 14, 2023
915bfb2
Update workflows.yml
ryanthemanuel Feb 14, 2023
99fc2bb
Merge branch 'develop' into ryanthemanuel-patch-2
ryanthemanuel Feb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions .circleci/workflows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ mainBuildFilters: &mainBuildFilters
only:
- develop
- /^release\/\d+\.\d+\.\d+$/
- 'mikep/22825-next-middleware'
# use the following branch as well to ensure that v8 snapshot cache updates are fully tested
- 'update-v8-snapshot-cache-on-develop'
Copy link
Member

@emilyrohrbough emilyrohrbough Feb 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update line 137 to always persist and run the full binary tests on this branch? https://github.com/cypress-io/cypress/pull/25784/files#diff-7bf091450b804ea25dc3d11ac28c50202d19178f7b53f54a02ad59c946afa6a7R137

Copy link
Collaborator Author

@ryanthemanuel ryanthemanuel Feb 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated: 4fcc2ef (#25784)


# usually we don't build Mac app - it takes a long time
# but sometimes we want to really confirm we are doing the right thing
Expand All @@ -37,7 +38,8 @@ macWorkflowFilters: &darwin-workflow-filters
when:
or:
- equal: [ develop, << pipeline.git.branch >> ]
- equal: [ 'mikep/22825-next-middleware', << pipeline.git.branch >> ]
# use the following branch as well to ensure that v8 snapshot cache updates are fully tested
- equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ]
- matches:
pattern: /^release\/\d+\.\d+\.\d+$/
value: << pipeline.git.branch >>
Expand All @@ -46,7 +48,8 @@ linuxArm64WorkflowFilters: &linux-arm64-workflow-filters
when:
or:
- equal: [ develop, << pipeline.git.branch >> ]
- equal: [ 'mikep/22825-next-middleware', << pipeline.git.branch >> ]
# use the following branch as well to ensure that v8 snapshot cache updates are fully tested
- equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ]
- matches:
pattern: /^release\/\d+\.\d+\.\d+$/
value: << pipeline.git.branch >>
Expand All @@ -64,7 +67,8 @@ windowsWorkflowFilters: &windows-workflow-filters
when:
or:
- equal: [ develop, << pipeline.git.branch >> ]
- equal: [ 'mschile/chrome_memory_fix', << pipeline.git.branch >> ]
# use the following branch as well to ensure that v8 snapshot cache updates are fully tested
- equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ]
- matches:
pattern: /^release\/\d+\.\d+\.\d+$/
value: << pipeline.git.branch >>
Expand Down