-
Notifications
You must be signed in to change notification settings - Fork 3.4k
feat: openInIDE for failed debug spec #25691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
36804c5
9a95508
6f36895
00c231e
dab6639
8ebd890
31bdc36
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,11 +16,64 @@ | |
| class="flex w-full grid px-18px gap-y-8px items-center" | ||
| > | ||
| <div class="flex-grow flex w-full gap-x-2 truncate items-center"> | ||
| <IconDocumentText | ||
| stroke-color="gray-500" | ||
| fill-color="gray-100" | ||
| size="16" | ||
| /> | ||
| <Tooltip | ||
| v-if="foundLocally" | ||
| placement="bottom" | ||
| color="dark" | ||
| data-cy="open-in-ide" | ||
| > | ||
ZachJW34 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| <OpenFileInIDE | ||
| v-slot="{onClick}" | ||
| :file-path="specData.fullPath" | ||
| > | ||
|
Comment on lines
+25
to
+28
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. When the user opens the IDE and then returns to the app, the tooltip reshows itself. Can this be closed on click or I saw there is an Screen.Recording.2023-02-03.at.10.15.51.AM.mov
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would say this is expected behavior. The tooltip shows on hover/focus, when you click back into the app the browser restores focus to the button, causing the tooltip to appear. You could probably workaround it, but I don't think the workaround would be worth the investment |
||
| <button | ||
| class="rounded-md border-1px border-gray-100 p-4px group hocus:border-indigo-200" | ||
| @click="onClick" | ||
| > | ||
ZachJW34 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| <IconDocumentText | ||
| stroke-color="gray-500" | ||
| fill-color="gray-100" | ||
| hocus-stroke-color="indigo-400" | ||
| hocus-fill-color="indigo-200" | ||
| size="16" | ||
| interactive-colors-on-group | ||
| /> | ||
| </button> | ||
| </OpenFileInIDE> | ||
| <template | ||
| #popper | ||
| > | ||
| <div | ||
| class="text-center text-sm max-w-240px" | ||
| data-cy="open-in-ide-tooltip" | ||
| > | ||
| {{ t('debugPage.openFile.openInIDE') }} | ||
| </div> | ||
| </template> | ||
| </Tooltip> | ||
| <Tooltip | ||
| v-else | ||
| class="rounded-md border-1px border-gray-100 p-4px" | ||
| placement="bottom" | ||
| color="dark" | ||
| data-cy="open-in-ide-disabled" | ||
| > | ||
ZachJW34 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| <IconDocumentMinus | ||
| stroke-color="gray-500" | ||
| fill-color="gray-100" | ||
| size="16" | ||
| /> | ||
| <template | ||
| #popper | ||
| > | ||
| <div | ||
| class="text-center text-sm max-w-240px" | ||
| data-cy="open-in-ide-disabled-tooltip" | ||
| > | ||
| {{ t('debugPage.openFile.notFoundLocally') }} | ||
| </div> | ||
| </template> | ||
| </Tooltip> | ||
| <div | ||
| data-cy="spec-path" | ||
| class="flex-grow text-base non-italic truncate" | ||
|
|
@@ -142,7 +195,7 @@ | |
| <script lang="ts" setup> | ||
|
|
||
| import { computed, unref } from 'vue' | ||
| import { IconActionRefresh, IconDocumentText } from '@cypress-design/vue-icon' | ||
| import { IconActionRefresh, IconDocumentText, IconDocumentMinus } from '@cypress-design/vue-icon' | ||
| import type { SpecDataAggregate, CloudRunInstance } from '@packages/data-context/src/gen/graphcache-config.gen' | ||
| import DebugFailedTest from './DebugFailedTest.vue' | ||
| import StatsMetaData from './StatsMetadata.vue' | ||
|
|
@@ -154,6 +207,7 @@ import { useI18n } from '@cy/i18n' | |
| import { useDurationFormat } from '../composables/useDurationFormat' | ||
| import { posixify } from '../paths' | ||
| import type { StatsMetadata_GroupsFragment, TestingTypeEnum } from '../generated/graphql' | ||
| import OpenFileInIDE from '@cy/gql-components/OpenFileInIDE.vue' | ||
|
|
||
| export interface Spec { | ||
| id: string | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.