fix: Aliases properly retry commands from inside custom commands

[BlueWinds]

• Closes alias returns undefined when there is a customized get command for the alias and I visit the page again #23652

User facing changelog

Fix: Mixing custom commands and aliases now works again. Fixes regression introduced between 10.4.0 and 10.5.0.

Additional details

When a custom command invoked cypress commands, these 'internal' commands' return values are properly used as the subject for future commands, via the 'subjectLinks' internal Cypress state.

However, as of 10.5.0, aliases were not respecting these links, meaning they would end up with 'undefined' for a subject instead of the proper one (which would come from replaying the 'internal' commands).

See the test added by this PR for a more concrete example.

Steps to test

Added automated test demonstrating the issue. Also see the repro in #23652 for external validation.

How has the user experience changed?

PR Tasks

• Have tests been added/updated?
• Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
• [n/a] Has a PR for user-facing changes been opened in cypress-documentation?
• [n/a] Have API changes been updated in the type definitions?

[cypress-bot]

Thanks for taking the time to open a PR!

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
• Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

[cypress]

---

Test summary

4718 • 0 • 381 • 0 • 1

---

Run details

Project	cypress
Status	Passed
Commit	5a44502
Started	Sep 1, 2022 9:17 PM
Ended	Sep 1, 2022 9:31 PM
Duration	14:49 💡
OS	Linux Debian - 11.3
Browser	Multiple

View run in Cypress Dashboard ➡️

---

Flakiness

	cypress/e2e/e2e/origin/commands/spies_stubs_clocks.cy.ts		1
1	cy.origin spies, stubs, and clock > spy()

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[rachelruderman]

Excelente! Tested locally with the OG issue and worked like a charm 🌟