Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow cy.visit to visit cross origin sites. #23297

Merged
merged 79 commits into from
Sep 15, 2022
Merged

feat: Allow cy.visit to visit cross origin sites. #23297

merged 79 commits into from
Sep 15, 2022

Commits on Jul 18, 2022

  1. Initial async changes

    @mjhenkes
    mjhenkes committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    5b5ea12 View commit details
    Browse the repository at this point in the history

  2. Small fixes and test updates.

    @mjhenkes
    mjhenkes committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    91678a8 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2022

  1. updating tests

    @mjhenkes
    mjhenkes committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    49c74a6 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2022

  1. Merge branch 'develop' into matth/cy-origin-async-attach

    @mjhenkes
    mjhenkes committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    e686ab4 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2022

  1. Fixes for cookie login tests

    @mjhenkes
    mjhenkes committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    e70fed9 View commit details
    Browse the repository at this point in the history

  2. remove the onlys

    @mjhenkes
    mjhenkes committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    382ad34 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2022

  1. Most tests passing

    @mjhenkes
    mjhenkes committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    206cbd8 View commit details
    Browse the repository at this point in the history

  2. Fix driver tests?

    @mjhenkes
    mjhenkes committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    b03269c View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2022

  1. fix firefox test?

    @mjhenkes
    mjhenkes committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    7754402 View commit details
    Browse the repository at this point in the history

  2. fix unit tests

    @mjhenkes
    mjhenkes committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    d6c5f45 View commit details
    Browse the repository at this point in the history

  3. fix tests??

    @mjhenkes
    mjhenkes committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    32ceeba View commit details
    Browse the repository at this point in the history

  4. a better check

    @mjhenkes
    mjhenkes committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    cd1a90c View commit details
    Browse the repository at this point in the history

  5. fix integration tests

    @mjhenkes
    mjhenkes committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    bb45506 View commit details
    Browse the repository at this point in the history

  6. minor cleanup

    @mjhenkes
    mjhenkes committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    1dc9554 View commit details
    Browse the repository at this point in the history

  7. Comment out tyler fix for 10.0 origin issue

    @mjhenkes
    mjhenkes committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    8ab2e61 View commit details
    Browse the repository at this point in the history

  8. also fix integration tests

    @mjhenkes
    mjhenkes committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    0d4d603 View commit details
    Browse the repository at this point in the history

  9. remove fixmes

    @mjhenkes
    mjhenkes committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    774da85 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2022

  1. Adding Retries for cookie actions. May break other error tests.

    @mjhenkes
    mjhenkes committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    2106204 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2022

  1. Address (some) PR comments

    @mjhenkes
    mjhenkes committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    9e20c9d View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2022

  1. Merge branch 'develop' into matth/cy-origin-async-attach

    @mjhenkes
    mjhenkes committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    c1b1790 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2022

  1. update to warn about cross origin command AUT in assertions

    @mjhenkes
    mjhenkes committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    e8e2b7e View commit details
    Browse the repository at this point in the history

  2. Fix type errors

    @mjhenkes
    mjhenkes committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    b6d4471 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2022

  1. Move document.cookie patch to injection

    @mjhenkes
    mjhenkes committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    ed4c1e3 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2022

  1. Adding iframe patching.

    @mjhenkes
    mjhenkes committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    0d19622 View commit details
    Browse the repository at this point in the history

  2. forward errors prior to attaching

    @mjhenkes
    mjhenkes committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    e985d24 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. Add error message when using visit to visit a cross origin site with … 

    …the onLoad or onBeforeLoad options.
    @mjhenkes
    mjhenkes committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    822aa81 View commit details
    Browse the repository at this point in the history

  2. Attempt to fix test errors.

    @mjhenkes
    mjhenkes committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    b0a31aa View commit details
    Browse the repository at this point in the history

  3. more fixes, but not all

    @mjhenkes
    mjhenkes committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    18af289 View commit details
    Browse the repository at this point in the history

  4. use the origin policy

    @mjhenkes
    mjhenkes committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    f8ca723 View commit details
    Browse the repository at this point in the history

  5. Fix types

    @mjhenkes
    mjhenkes committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    0453a4b View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. more fixes

    @mjhenkes
    mjhenkes committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    bd16d86 View commit details
    Browse the repository at this point in the history

  2. consider chromeWebSecurity when checking if you can communicate with … 

    …the AUT
    @mjhenkes
    mjhenkes committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    bbe5a5f View commit details
    Browse the repository at this point in the history

  3. firefox

    @mjhenkes
    mjhenkes committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    55e9aa3 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into matth/cy-origin-async-attach

    @mjhenkes
    mjhenkes committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    b221942 View commit details
    Browse the repository at this point in the history

  5. prevent hangs if before unload happens after on load.

    @mjhenkes
    mjhenkes committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    6f12700 View commit details
    Browse the repository at this point in the history

  6. Fix some ToDos

    @mjhenkes
    mjhenkes committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    61435ba View commit details
    Browse the repository at this point in the history

  7. code cleanup

    @mjhenkes
    mjhenkes committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    49b7f87 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2022

  1. remove quotes

    @mjhenkes
    mjhenkes committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    45479f6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into matth/cy-origin-async-attach

    @mjhenkes
    mjhenkes authored Sep 8, 2022
    Configuration menu
    Copy the full SHA
    4a0bd08 View commit details
    Browse the repository at this point in the history

  3. Code review changes

    @mjhenkes
    mjhenkes committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    9319e2b View commit details
    Browse the repository at this point in the history

  4. more cr changes

    @mjhenkes
    mjhenkes committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    bf01ddd View commit details
    Browse the repository at this point in the history

  5. fix tests possibly

    @mjhenkes
    mjhenkes committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    f33b059 View commit details
    Browse the repository at this point in the history

  6. for realz this time

    @mjhenkes
    mjhenkes committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    60ea312 View commit details
    Browse the repository at this point in the history

  7. roll back change

    @mjhenkes
    mjhenkes committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    6f24105 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'develop' into matth/cy-origin-async-attach

    @mjhenkes
    mjhenkes authored Sep 8, 2022
    Configuration menu
    Copy the full SHA
    c061c36 View commit details
    Browse the repository at this point in the history

  9. Fix some flake

    @mjhenkes
    mjhenkes committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    accee35 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2022

  1. Fix flakey xhr test hopefully.

    @mjhenkes
    mjhenkes committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    e545a2b View commit details
    Browse the repository at this point in the history

  2. oops, forgot communicator changes. need those.

    @mjhenkes
    mjhenkes committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    034c2dd View commit details
    Browse the repository at this point in the history

  3. modify error message to not lose the original error

    @mjhenkes
    mjhenkes committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    d8ded03 View commit details
    Browse the repository at this point in the history

  4. read config right derp

    @mjhenkes
    mjhenkes committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    1d1d276 View commit details
    Browse the repository at this point in the history

  5. simpler check

    @mjhenkes
    mjhenkes committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    8fe413f View commit details
    Browse the repository at this point in the history

  6. no unused vars

    @mjhenkes
    mjhenkes committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    4db7732 View commit details
    Browse the repository at this point in the history

  7. don't put config on window

    @mjhenkes
    mjhenkes committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    8ec97f1 View commit details
    Browse the repository at this point in the history

  8. Make isRunnerAbleToCommunicateWithTheAUT a util function instead of a… 

    …ttaching it to cypress.
    @mjhenkes
    mjhenkes committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    eecc830 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2022

  1. fix a race condition maybe

    @mjhenkes
    mjhenkes committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    cd24553 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into matth/cy-origin-async-attach

    @mjhenkes
    mjhenkes authored Sep 12, 2022
    Configuration menu
    Copy the full SHA
    a981b51 View commit details
    Browse the repository at this point in the history

  3. clear document when window is cross origin... we'll see if this break… 

    …s anything.
    @mjhenkes
    mjhenkes committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    1d198de View commit details
    Browse the repository at this point in the history

  4. Retry if querying against the wrong AUT

    @mjhenkes
    mjhenkes committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    e2b15b3 View commit details
    Browse the repository at this point in the history

  5. use timeout

    @mjhenkes
    mjhenkes committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    fac4590 View commit details
    Browse the repository at this point in the history

  6. Don't print the retrying string unless you're retrying due to command… 

    … aut origin mismatch
    @mjhenkes
    mjhenkes committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    d8808f2 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2022

  1. try handling undefined document

    @mjhenkes
    mjhenkes committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    dca3885 View commit details
    Browse the repository at this point in the history

  2. Code review updates. What could go wrong??

    @mjhenkes
    mjhenkes committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    5ddf538 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Bill Glesias <[email protected]>
    @mjhenkes @AtofStryker
    mjhenkes and AtofStryker authored Sep 13, 2022
    Configuration menu
    Copy the full SHA
    e209865 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into matth/cy-origin-async-attach

    @mjhenkes
    mjhenkes authored Sep 13, 2022
    Configuration menu
    Copy the full SHA
    62ee89f View commit details
    Browse the repository at this point in the history

  5. minor fixes

    @mjhenkes
    mjhenkes committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    9464631 View commit details
    Browse the repository at this point in the history

  6. try aut location and move the async state collection.

    @mjhenkes
    mjhenkes committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    62bc8ce View commit details
    Browse the repository at this point in the history

  7. Merge branch 'develop' into matth/cy-origin-async-attach

    @mjhenkes
    mjhenkes authored Sep 13, 2022
    Configuration menu
    Copy the full SHA
    6e4e84f View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2022

  1. fix flake around the loading message, probably

    @mjhenkes
    mjhenkes committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    fd65ead View commit details
    Browse the repository at this point in the history

  2. Fix system tests and some flake around redirect counts.

    @mjhenkes
    mjhenkes committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    777d524 View commit details
    Browse the repository at this point in the history

  3. Improve error handler prior to attaching.

    @mjhenkes
    mjhenkes committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    98ee462 View commit details
    Browse the repository at this point in the history

  4. Code review suggestions

    @mjhenkes
    mjhenkes committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    39c442c View commit details
    Browse the repository at this point in the history

  5. use a generated ID when promisifying post message

    @mjhenkes
    mjhenkes committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    627f886 View commit details
    Browse the repository at this point in the history

  6. clean up promise helper

    @mjhenkes
    mjhenkes committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    641a15c View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2022

  1. skip xhr test until issue is resolved.

    @mjhenkes
    mjhenkes committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    ef7d6b2 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Chris Breiding <[email protected]>
    @mjhenkes @chrisbreiding
    mjhenkes and chrisbreiding authored Sep 15, 2022
    Configuration menu
    Copy the full SHA
    eb5860e View commit details
    Browse the repository at this point in the history

  3. use state directly

    @mjhenkes
    mjhenkes committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    294bc3e View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Bill Glesias <[email protected]>
    @mjhenkes @AtofStryker
    mjhenkes and AtofStryker authored Sep 15, 2022
    Configuration menu
    Copy the full SHA
    61f1122 View commit details
    Browse the repository at this point in the history

  5. Update packages/driver/src/cypress/error_messages.ts 

    Co-authored-by: Chris Breiding <[email protected]>
    @mjhenkes @chrisbreiding
    mjhenkes and chrisbreiding authored Sep 15, 2022
    Configuration menu
    Copy the full SHA
    e10dc28 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'develop' into matth/cy-origin-async-attach

    @mjhenkes
    mjhenkes authored Sep 15, 2022
    Configuration menu
    Copy the full SHA
    04a8290 View commit details
    Browse the repository at this point in the history