Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing types to exports #22498

Merged
merged 2 commits into from
Jul 11, 2022

Conversation

smmccabe
Copy link
Contributor

@smmccabe smmccabe requested a review from a team as a code owner June 24, 2022 00:07
@smmccabe smmccabe requested review from chrisbreiding and removed request for a team June 24, 2022 00:07
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 24, 2022

Thanks for taking the time to open a PR!

@CLAassistant
Copy link

CLAassistant commented Jun 24, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some external contributor specific flake. The code is fine, I will find out what's the deal with CI and fix it for you. Thank you for this contribution.

@louisscruz
Copy link

@lmiller1990 Any status update? As mentioned here, I've verified that this change fixes the type resolution in one of our projects.

@lmiller1990
Copy link
Contributor

Sorry, I was out for one week, but now I am back. I will try to get this merged within 24 hours.

@cypress
Copy link

cypress bot commented Jul 11, 2022



Test summary

9283 0 110 0Flakiness 0


Run details

Project cypress
Status Passed
Commit 275efb9
Started Jul 11, 2022 3:26 AM
Ended Jul 11, 2022 3:41 AM
Duration 15:07 💡
OS Linux Debian - 10.11
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@lmiller1990 lmiller1990 merged commit 3afe3d4 into cypress-io:develop Jul 11, 2022
rubinda pushed a commit to rubinda/cypress that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript 4.7 with new moduleResolution mode node16/nodenext does not resolve types
5 participants