-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing types to exports #22498
Conversation
Thanks for taking the time to open a PR!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is some external contributor specific flake. The code is fine, I will find out what's the deal with CI and fix it for you. Thank you for this contribution.
@lmiller1990 Any status update? As mentioned here, I've verified that this change fixes the type resolution in one of our projects. |
Sorry, I was out for one week, but now I am back. I will try to get this merged within 24 hours. |
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Co-authored-by: Matt Henkes <[email protected]>
exports were added to the package.json, these are missing types settings and don't work with typescript and node16 style moduleResolution. see microsoft/TypeScript#33079 and https://devblogs.microsoft.com/typescript/announcing-typescript-4-7-beta/#package-json-exports-imports-and-self-referencing