-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: proxy authorization type Basic #22471
fix: proxy authorization type Basic #22471
Conversation
Thanks for taking the time to open a PR!
|
@Buluc-Celik Thank you for the contribution! Can you please sign the CLA Agreement so we can move forward with this change? |
hi @emilyrohrbough I have signed it, I think it needs a bit of time to reflect though |
@Buluc-Celik are you toggling between two git accounts? |
Sorry about that, signed with both now |
@Buluc-Celik no worries 😄 |
Looks good. We've got some flake blocking merging, but I can take it from here - it's not related to your change. Thanks! |
Thank you! |
Hi, do you mind re-running the failed flaky test a few times to get this through, please? I would really like to get this in the next version and start using it. |
Sure, I think the flake is fixed now. I will re-run. |
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Less flake but still something isn't passing - figuring it out, thanks for waiting. |
@Buluc-Celik-Ozbul] please wait a moment - I am going to get this merged. If you keep back merging, it re runs everything. I can run "only from failed" which is more likely to succeed. I can take it from here. |
Sure, thank you |
Thanks for your patience @Buluc-Celik-Ozbul - this will be in the next release. Those are usually every two weeks at maximum. |
Thanks again! |
User facing changelog
The Proxy-Authorization header when present with basic authorization will read "Basic" with a capital "B".
Additional details
When I set up a proxy with username and password, the Proxy-Authorization header is created with basic type but it says "basic" with a small "b" and this fails with some proxies. The Proxy-Authorization header should have been created with "Basic" keyword with a capital "B"
Steps to test
[na]
How has the user experience changed?
[na]
PR Tasks
[na]
cypress-documentation
?type definitions
?