Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add padding to bottom of global mode list #22112

Merged
merged 15 commits into from
Jun 30, 2022
Merged

fix: add padding to bottom of global mode list #22112

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
7ef8f9c
fix: add padding
viniciuspietscher Jun 5, 2022
7b6f09b
fix: add padding (#21724)
viniciuspietscher Jun 5, 2022
2fb9834
Update packages/launchpad/src/global/GlobalPage.cy.tsx
viniciuspietscher Jun 5, 2022
23b03ef
Merge branch 'develop' into issue-21724
marktnoonan Jun 8, 2022
b4d5e8d
Merge branch 'develop' into issue-21724
viniciuspietscher Jun 8, 2022
9c22538
no longer necessary for this fix
viniciuspietscher Jun 8, 2022
08af079
no longer necessary padding will be added to Main.vue
viniciuspietscher Jun 8, 2022
3489f7f
add bottom padding
viniciuspietscher Jun 8, 2022
d9210a0
add percy test
viniciuspietscher Jun 8, 2022
d571c0e
Merge branch 'develop' into issue-21724
marktnoonan Jun 14, 2022
869cf45
Merge branch 'develop' into issue-21724
tbiethman Jun 16, 2022
6d12fac
Merge branch 'develop' into issue-21724
marktnoonan Jun 22, 2022
4df3b79
move percy snapshot out of helper function
marktnoonan Jun 22, 2022
ae61f44
Merge branch 'develop' into issue-21724
lmiller1990 Jun 27, 2022
a801cd2
Merge branch 'develop' into issue-21724
flotwig Jun 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/launchpad/src/global/GlobalPage.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,13 @@ describe('<GlobalPage />', { viewportHeight: 900, viewportWidth: 1200 }, () => {
it('renders projects', () => {
cy.findByText(testProject).should('be.visible')
cy.findByText(testProjectPath).should('be.visible')
// validate that there is some padding on the bottom
cy.get('[data-cy="project-card"]')
.parent()
.invoke('outerHeight')
.then((parentHeight) => {
cy.get('[data-cy="project-card"]').invoke('outerHeight').should('be.lt', parentHeight)
viniciuspietscher marked this conversation as resolved.
Show resolved Hide resolved
})
})

it('can filter down the projects by name', () => {
Expand Down
5 changes: 4 additions & 1 deletion packages/launchpad/src/global/GlobalPage.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@
>
{{ t('globalPage.recentProjectsHeader') }}
</h2>
<div :class="{ 'md:grid md:grid-cols-2 md:gap-24px mb-0': filteredProjects?.length > 1 }">
<div
class="pb-24px"
:class="{ 'md:grid md:grid-cols-2 md:gap-24px mb-0': filteredProjects?.length > 1 }"
>
<GlobalProjectCard
v-for="project in filteredProjects"
:key="project.id"
Expand Down