-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: (cross-origin) add support for redirecting back to primary #21144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschile
requested review from
chrisbreiding,
mjhenkes,
AtofStryker and
emilyrohrbough
April 20, 2022 03:15
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
AtofStryker
requested changes
Apr 20, 2022
packages/driver/cypress/integration/e2e/multi-domain/commands/multi_domain_navigation.spec.ts
Show resolved
Hide resolved
mschile
commented
Apr 20, 2022
Co-authored-by: Bill Glesias <[email protected]>
AtofStryker
approved these changes
Apr 20, 2022
mjhenkes
reviewed
Apr 20, 2022
mjhenkes
reviewed
Apr 20, 2022
mjhenkes
reviewed
Apr 20, 2022
mjhenkes
reviewed
Apr 20, 2022
mjhenkes
approved these changes
Apr 20, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
n/a
Additional details
cy.visit
'ing urls that redirect back to the primary domaincy.visit
for the redirect must be placed in the context of the origin of the final redirectcy.origin
command on thebridge:ready
message instead of theready:for:origin
messagecy.visit
in the correct contextready:for:origin
tocross:origin:release:html
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?