Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: (cross-origin) add support for redirecting back to primary #21144

Merged
merged 9 commits into from
Apr 21, 2022

Conversation

mschile
Copy link
Contributor

@mschile mschile commented Apr 20, 2022

User facing changelog

n/a

Additional details

  • Added support forcy.visit'ing urls that redirect back to the primary domain
    • The cy.visit for the redirect must be placed in the context of the origin of the final redirect
    • The remote state is updated with the origin of the cy.origin command on the bridge:ready message instead of the ready:for:origin message
    • Updated error message to instruct user to place the cy.visit in the correct context
  • Renamed ready:for:origin to cross:origin:release:html

How has the user experience changed?

Screen Shot 2022-04-19 at 5 52 32 PM

PR Tasks

  • Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 20, 2022

Thanks for taking the time to open a PR!

@mschile mschile removed request for a team April 20, 2022 03:16
@cypress
Copy link

cypress bot commented Apr 20, 2022



Test summary

20743 0 258 4Flakiness 0


Run details

Project cypress
Status Passed
Commit 2fe3dea
Started Apr 21, 2022 4:30 AM
Ended Apr 21, 2022 4:47 AM
Duration 16:33 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@mschile mschile merged commit d7ce865 into feature-multidomain Apr 21, 2022
@mschile mschile deleted the md-redirect-to-primary branch April 21, 2022 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants