Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add type definitions for Cypress.off #1514

Merged
merged 5 commits into from
Apr 15, 2018
Merged

feat: Add type definitions for Cypress.off #1514

merged 5 commits into from
Apr 15, 2018

Conversation

NicholasBoll
Copy link
Contributor

@NicholasBoll NicholasBoll commented Mar 28, 2018 •
edited
Loading

Adds Cypress.off type definitions using the same Actions types used by Cypress.on from #1187

bahmutov
bahmutov suggested changes Apr 4, 2018
View reviewed changes
Copy link
Contributor

@bahmutov bahmutov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add off to the chain command (same two places as on)

@NicholasBoll
Copy link
Contributor Author

@bahmutov Thanks for taking a close look. I will update

@NicholasBoll
Copy link
Contributor Author

@bahmutov I added the cy.off and added JSDoc documentation and some type tests

@bahmutov
Copy link
Contributor

loving this now

@jennifer-shehane jennifer-shehane modified the milestones: 2.2.0, 3.0.0 Apr 10, 2018
@brian-mann brian-mann merged commit 075a3a0 into cypress-io:develop Apr 15, 2018
@brian-mann brian-mann mentioned this pull request Apr 15, 2018
Closed
@brian-mann brian-mann removed this from the 3.0.0 milestone Apr 15, 2018
@NicholasBoll NicholasBoll deleted the feat/cypress-off branch April 15, 2018 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bahmutov bahmutov bahmutov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NicholasBoll @bahmutov @brian-mann @jennifer-shehane