Skip to content

Conversation

@mishabruml
Copy link
Contributor

added keyboard shortcuts to docs, close #1904

@jennifer-shehane jennifer-shehane changed the base branch from develop to 3.5.0-release-changes October 4, 2019 15:13
- This document could live for another year - so saying ‘we’ve added’
will quickly be outdated.
- Add a ‘History’ section to indicate that keyboard shortcuts only work
in 3.5.0+
@jennifer-shehane jennifer-shehane self-requested a review October 4, 2019 15:30
@CLAassistant
Copy link

CLAassistant commented Oct 4, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! Made a few edits, but good to merge after that.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ kevinold
❌ Misha Bruml


Misha Bruml seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mishabruml
Copy link
Contributor Author

Thanks for adding this! Made a few edits, but good to merge after that.

No worries, happy to help, the only problem is I'm having issues with the CLA, I've hit the cloudflare error page so perhaps the service is down?

@jennifer-shehane
Copy link
Member

Yup, cla-assistant is down. Opened an issue cla-assistant/cla-assistant#493

@mishabruml
Copy link
Contributor Author

@jennifer-shehane jennifer-shehane merged commit f1388a9 into cypress-io:3.5.0-release-changes Oct 7, 2019
@jennifer-shehane jennifer-shehane mentioned this pull request Jan 29, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants