Issue-2027 #2028
Merged
Issue-2027 #2028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirrustam
suggested changes
Aug 19, 2019
Contributor
There was a problem hiding this comment.
@TonySynenko can you please add tests for emojiStrip. It only gets used with dynamically picked content. It would be great to have tests to see if it can properly handle the various permutations of Contentful content..
amirrustam
approved these changes
Aug 23, 2019
Contributor
amirrustam
left a comment
amirrustam
left a comment
There was a problem hiding this comment.
I would prefer a third-party module to handle the emoji strip, but we need to get this fix out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.