Skip to content

refactor cy.route "delays for responses" copy to avoid wait antipattern#1968

Closed
csi-lk wants to merge 1 commit intocypress-io:developfrom
csi-lk:patch-1
Closed

refactor cy.route "delays for responses" copy to avoid wait antipattern#1968
csi-lk wants to merge 1 commit intocypress-io:developfrom
csi-lk:patch-1

Conversation

@csi-lk
Copy link

@csi-lk csi-lk commented Aug 6, 2019

  • Suggest using onRequest / onResponse for testing loading states instead of delay

See #1967 for more info

Translations updated

Changes made to documentation were also copied over to other languages (copying English text is ok).

  • Japanese docs in /source/ja.
  • Chinese docs in /source/zh-cn.
  • Not applicable (this is not a change to an en doc content).

* Suggest using `onRequest` / `onResponse` for testing loading states instead of `delay`

resolves cypress-io#1967
@CLAassistant
Copy link

CLAassistant commented Aug 6, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jennifer-shehane
Copy link
Member

Closing due to inactivity .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants