Skip to content

Conversation

@jennifer-shehane
Copy link
Member

No description provided.

cedricss and others added 10 commits July 30, 2019 13:32
* Improve GitHub integration "run group" link target

* Update ja locale link

* Update zh-cn locale link

* Use internal link syntax
* data fetch && swig && styles

* banners actualization script

* finish (?)

* finish (?)

* remove "extends" from eslint settings

* remove sensitive info

* update hexo index file

* banner padding fix

* remove Promise.protoype.finally() from hexo index script

* Contentful driven banners, parsed dynamically:
Hexo index.js && data fetch && swig && styles && banners_actualization script

* add cypress test for banners

* docs update v1

* Fix toc width so that it doesn't create a horizontal scrollbar on smaller heights screen.

* package-lock

* just a few tweaks to the README instructions

* fixed conflict issue from package.json merge
* add GitHub Enterprise integration support notice

* add japanese and chinese versions
@jennifer-shehane
Copy link
Member Author

K, so I'm realizing there is an issue with the new banner - that the tests on docs-staging caught (not sure why it wasn't caught before), but the banner now pushed down the content of the page so that when you click on the rightside table of contents - it no longer correctly scrolls to the h1, h2, etc - the h1, h2 slides undernearth the nav as shown.

Clicked on "Who Uses Cypress"

Screen Shot 2019-07-31 at 5 59 13 PM

Looking into fixing this now.

@jennifer-shehane
Copy link
Member Author

omg, look at these beautiful cypress GitHub checks. 😍

@cypress
Copy link

cypress bot commented Aug 1, 2019



Test summary

30 0 0 0


Run details

Project cypress-documentation
Status Passed
Commit fa2eed7
Started Aug 2, 2019 7:41 AM
Ended Aug 2, 2019 7:43 AM
Duration 02:20 💡
OS Linux Debian - 9.9
Browser Electron 61

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

jennifer-shehane and others added 6 commits August 1, 2019 11:08
- instead of regex removals, use utf8 encode the html content provided
- use Cypress commands instead of direct javascript - so we can have
better logs during CI runs and also have retryability.
- Basically - we’re done parsing that HTML, what a mess. Only going to
parse the text within the HTML now for the tests.
- Add an html entity within the banners.yml so we make sure these are
tested.
@jennifer-shehane
Copy link
Member Author

So, now the populated changelog is the only failing test - which makes sense because this test is not run in development.

Actually...I think there may be a bug in Cypress that is causing this failure. So...that's fun. 😬

Screen Shot 2019-08-01 at 2 02 54 PM

jennifer-shehane and others added 2 commits August 1, 2019 14:40
* add cy.get by name attribute example

* copy to ja/cn


Co-authored-by: Jennifer Shehane <[email protected]>
@jennifer-shehane
Copy link
Member Author

jennifer-shehane commented Aug 1, 2019

DON'T MERGE: When clicking on table of contents - the article content slides under the header. We should probably write a test for this (click toc - make sure h2 is.visible)

Screen Shot 2019-08-01 at 3 38 45 PM

bahmutov and others added 2 commits August 1, 2019 09:57
* add robots.txt and copy it to public folder during build

* add robots.txt test

* add custom methods on Cypress for checking env name

* switch another spec to use method
* temporary workaround for hash scroll

* Add tests to ensure the docs scroll properly when clicking on a toc link


Co-authored-by: null <[email protected]>
Co-authored-by: Jennifer Shehane <[email protected]>
@jennifer-shehane jennifer-shehane merged commit b340c89 into master Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants