-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Develop #1928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #1928
Conversation
Co-authored-by: Renovate Bot <[email protected]>
- also alphabetize requirements methods
* Improve GitHub integration "run group" link target * Update ja locale link * Update zh-cn locale link * Use internal link syntax
Co-authored-by: Renovate Bot <[email protected]>
* data fetch && swig && styles * banners actualization script * finish (?) * finish (?) * remove "extends" from eslint settings * remove sensitive info * update hexo index file * banner padding fix * remove Promise.protoype.finally() from hexo index script * Contentful driven banners, parsed dynamically: Hexo index.js && data fetch && swig && styles && banners_actualization script * add cypress test for banners * docs update v1 * Fix toc width so that it doesn't create a horizontal scrollbar on smaller heights screen. * package-lock * just a few tweaks to the README instructions * fixed conflict issue from package.json merge
* add GitHub Enterprise integration support notice * add japanese and chinese versions
|
K, so I'm realizing there is an issue with the new banner - that the tests on docs-staging caught (not sure why it wasn't caught before), but the banner now pushed down the content of the page so that when you click on the rightside table of contents - it no longer correctly scrolls to the h1, h2, etc - the h1, h2 slides undernearth the nav as shown. Clicked on "Who Uses Cypress" Looking into fixing this now. |
|
omg, look at these beautiful cypress GitHub checks. 😍 |
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
- instead of regex removals, use utf8 encode the html content provided - use Cypress commands instead of direct javascript - so we can have better logs during CI runs and also have retryability.
- Basically - we’re done parsing that HTML, what a mess. Only going to parse the text within the HTML now for the tests. - Add an html entity within the banners.yml so we make sure these are tested.
…to run hexo.init if failed
Co-authored-by: null <[email protected]>
* add cy.get by name attribute example * copy to ja/cn Co-authored-by: Jennifer Shehane <[email protected]>
* add robots.txt and copy it to public folder during build * add robots.txt test * add custom methods on Cypress for checking env name * switch another spec to use method
* temporary workaround for hash scroll * Add tests to ensure the docs scroll properly when clicking on a toc link Co-authored-by: null <[email protected]> Co-authored-by: Jennifer Shehane <[email protected]>



No description provided.