fix: remove obsolete environment variable npm_config_unsafe_perm #1078
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
cypress-docker-images/factory/factory.Dockerfile
Lines 14 to 15 in b32255e
This environment variable is obsolete.
Background
The lowest supported Node.js version is Node.js 18.0.0 which bundles npm
8.6.0
. (See Node.js Release schedule.)The npm CHANGELOG 7.0.0 > All Lifecycle Scripts says:
The environment variable
npm_config_unsafe_perm
is no longer needed or used, since the current lowest supported version of npm (8.6.0
) is higher than the version where its used was removed (7.0.0
). Even considering Node.js 16.0.0 the lowest npm version is7.10.0
, which is already higher than the version whereunsafe_perm
was removed.Change
Remove the environment variable
npm_config_unsafe_perm
from the factory/factory.Dockerfile file.Bump
FACTORY_VERSION
.Verification