Refactor to use new ResourceId from reactor crate #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloudhead
reviewed
Dec 19, 2023
Cargo.toml
Outdated
| @@ -38,3 +38,6 @@ log = ["log_crate", "io-reactor/log"] | |||
| [package.metadata.docs.rs] | |||
| all-features = true | |||
| rustc-args = ["--cfg", "docsrs"] | |||
|
|
|||
| [patch.crates-io] | |||
| io-reactor = { git = "https://github.com/rust-amplify/io-reactor", branch = "resourceid" } | |||
There was a problem hiding this comment.
Note to remove this once io-reactor patch is merged
cloudhead
reviewed
Dec 19, 2023
src/resource.rs
Outdated
| } | ||
| self.id = Some(id); | ||
| Ok(()) | ||
| } |
There was a problem hiding this comment.
In the logging above
There was a problem hiding this comment.
I mean inside the new display method, which is called by each logging line in the file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on rust-amplify/io-reactor#23
The only issue was the fact that we used resource id in the debug logging. Thus, I added a way to add it to the net session after it is registered with the reactor (it will be returned from the registration method). Before that it defaults to printing information about the underlying net session.