Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add divided burger #27

Merged
merged 8 commits into from
Dec 10, 2020
Merged

Add divided burger #27

merged 8 commits into from
Dec 10, 2020

Conversation

ekrzeptowski
Copy link
Contributor

No description provided.

@luukdv
Copy link
Collaborator

luukdv commented Dec 9, 2020

Hi @saj96n,

Thanks for this tasty burger! I love it.

There are few (tiny) things I've changed, hope you don't mind. I appreciate the attention to detail you put in.

  • Changed the name from Divided to Divide to be consistent with the other verbs
  • Moved the new burger up in the documentation list
  • Removed the new halfBar prop in favor of exposing width to components, since it doesn't make that much sense for the other burgers
  • Some tiny formatting and alignment details

@luukdv
Copy link
Collaborator

luukdv commented Dec 9, 2020

I've increased the translation of the middle bar a bit as well, to make the animation somewhat more pronounced. What do you think?

@luukdv luukdv self-assigned this Dec 9, 2020
@ekrzeptowski
Copy link
Contributor Author

It looks good to me

@luukdv luukdv merged commit 273bd6e into cyntler:master Dec 10, 2020
@luukdv luukdv removed their assignment May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ekrzeptowski @luukdv