Proposal: Replace default color value with currentColor #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great idea, thanks again! I'm afraid I'll have to bump the version to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the TypeScript changes I was excited to be able to utilize the package, but I immediately noticed the default value for the
colorproperty being slightly non-intuitive.currentColoris a well-supported value forbackgrund-colorand other similar CSS properties, referring to the element's currentcolor. Using this value as the default lets developers keep the code DRY while integrating the burger icon with their projects by eliminating the need to duplicate color values that already come from the page's CSS.