cat-log: clean up processes on websocket disconnect #643
Comments
oliver-sanders
added a commit
to oliver-sanders/cylc-uiserver
that referenced
this issue
Nov 11, 2024
* Partially addresses cylc#643 * Add a timeout to `cylc cat-log` processes: * Ensures we don't accumulate them by accident. * Improves efficiency by closing long-lived log streams (the user probably isn't looking at the log file any more and the log file has probably stopped growing anyway). * At present, `cylc cat-log` processes may be left behind if the websocket is closed abruptly. This has been observed as the result of a proxy timeout.
oliver-sanders
added a commit
to oliver-sanders/cylc-uiserver
that referenced
this issue
Nov 11, 2024
* Partially addresses cylc#643 * Add a timeout to `cylc cat-log` processes: * Ensures we don't accumulate them by accident. * Improves efficiency by closing long-lived log streams (the user probably isn't looking at the log file any more and the log file has probably stopped growing anyway). * At present, `cylc cat-log` processes may be left behind if the websocket is closed abruptly. This has been observed as the result of a proxy timeout.
8 tasks
oliver-sanders
added a commit
to oliver-sanders/cylc-uiserver
that referenced
this issue
Nov 12, 2024
* Partially addresses cylc#643 * Add a timeout to `cylc cat-log` processes: * Ensures we don't accumulate them by accident. * Improves efficiency by closing long-lived log streams (the user probably isn't looking at the log file any more and the log file has probably stopped growing anyway). * At present, `cylc cat-log` processes may be left behind if the websocket is closed abruptly. This has been observed as the result of a proxy timeout.
oliver-sanders
added a commit
to oliver-sanders/cylc-uiserver
that referenced
this issue
Nov 12, 2024
* Partially addresses cylc#643 * Add a timeout to `cylc cat-log` processes: * Ensures we don't accumulate them by accident. * Improves efficiency by closing long-lived log streams (the user probably isn't looking at the log file any more and the log file has probably stopped growing anyway). * At present, `cylc cat-log` processes may be left behind if the websocket is closed abruptly. This has been observed as the result of a proxy timeout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I suspect that
cylc cat-logprocesses created to satisfy theLogDatasubscription, are not killed if the websocket is closed.Ideally, we would detect the websocket close event, and kill the subprocess.
If this is not possible, a bandage might be to apply a (generous) timeout to the
cylc cat-logprocess to ensure these processes are cleaned up eventually. This might actually be a good idea in general provided the default timeout is long enough not to cause user freustration.The text was updated successfully, but these errors were encountered: