fix a couple of possible errors #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 16, 2023
MetRonnie
approved these changes
Oct 17, 2023
Comment on lines
+25
to
31
| if (node.familyTree?.length) { | ||
| const rootFamily = node.familyTree[0] | ||
| return rootFamily.children | ||
| } else { | ||
| return [] | ||
| } | ||
| return rootFamily.children | ||
| } |
There was a problem hiding this comment.
Note this can be a 1-liner if you prefer
return node.familyTree?.[0]?.children ?? []Or
const rootFamily = node.familyTree?.[0]
return rootFamily?.children ?? []There was a problem hiding this comment.
I don't prefer those, they read very complex.
|
Tested both bugs - could reproduce on master but not on this branch ✔️
|
* Fixes an issue where a task might not have a firstParent. * Closes cylc#1470 * Fixes a traceback when opening the tree view. * To replicate, close all views, open the simple tree view, wait for it to load, then open the tree view.
MetRonnie
approved these changes
Oct 18, 2023
hjoliver
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.