Fix message chips for task outputs #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The chip text should be the output, the tooltip should be the message
7 tasks
Oops, not sure how we got that wrong! |
MetRonnie
commented
Sep 13, 2023
| "messages": ["started", "foo", "bar", "baz", "pub", "qux", "x", "y"], | ||
| "messages": ["started", "foo message", "bar message", "x", "baz message", "pub message", "qux message", "y"], |
There was a problem hiding this comment.
(I moved x up so we get a mix of outputs and non-outputs visible in the offline mode; previously x and y were hidden as beyond the max number shown)
oliver-sanders
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The chip text should be the output; the tooltip should be the message (this was backwards before)
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.CHANGES.mdentry included if this is a change that can affect users