subprocpool: populate missing 255 callback arguments #6376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing these exact lines is rather awkward, however, they are covered. |
* In some situations, these missing arguments could cause tasks to submit fail as the result of a host outage rather than moving onto the next host for the platform.
oliver-sanders
force-pushed
the
subprocpool-forward-255-args
branch
from
891a9b9 to
8c53251
Compare
wxtim
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Makes sense and fixes a breakage that I introduced all the way back in intelligent host selection (oops). I'd have been happier with it explicitly causing a test failure, but this isn't an easy one to simulate.
Do you want a second review given the lack of tests?
oliver-sanders
requested review from
hjoliver and
MetRonnie
and removed request for
hjoliver
hjoliver
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some situations, these missing arguments could cause tasks to submit fail as the result of a host outage rather than moving onto the next host for the platform.
The bug is as old as the 255 callback - https://github.com/cylc/cylc-flow/pull/4184/files#diff-577155476a8501cbb774dad9dfc50a2ed7b846d577835e58d9bb4dfdb5d56b34R243-R244
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).?.?.xbranch.