pool: warn when triggering queued tasks in different flows #6232
Conversation
* The `--flow` argument is ignored if you trigger a queued task. * It would be possible, though tricky, to merge the flows at this point as queued tasks already have database entries. * This PR will log a warning to let the user know / leave some record that the trigger did not take effect. * Closes cylc#6174
I don't think it is tricky, unless I'm missing something. I'll put up another PR to possibly supersede this one... |
| this behaviour at a later date, however, it is tricky as at present the | ||
| task's entry in the task_outputs table already exists by this point. |
There was a problem hiding this comment.
OK this is why you thought it's tricky. Actually the same thing happens with any flow merge, since it only occurs if a flow runs into an existing n=0 task. We just add a new flow row in the DB:
$ sqlite3 ~/cylc-run/bug/runN/log/db "select * from task_outputs"
1|bar|[1]|{"submitted": "submitted", "started": "started"}
1|foo|[1]|{} # <--- pre merge, waiting
1|foo|[1, 2]|{"submitted": "submitted", "started": "started"} # <--- post merge, runningThere was a problem hiding this comment.
Isn't it a problem leaving the [1] task behind in the DB?
There was a problem hiding this comment.
How is it a problem?
On the plus side, you can see exactly what happened (flow merge when foo was waiting).
And, as I said, the same thing happens for normal (non manual trigger) flow merges.
|
Superseded by #6241 |
--flowargument is ignored if you trigger a queued task.Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).?.?.xbranch.