Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cylc lint: deprecate [cylc-lint] in favour of [tool.cylc.lint] in pyproject.toml #5956

Merged
merged 3 commits into from
Feb 9, 2024

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Feb 1, 2024

Closes #5811

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • No dependency changes
  • Tests are included
  • CHANGES.md entry included if this is a change that can affect users
  • Update docs for cylc lint cylc-doc#687
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@MetRonnie MetRonnie added this to the cylc-8.3.0 milestone Feb 1, 2024
@MetRonnie MetRonnie self-assigned this Feb 1, 2024
@MetRonnie MetRonnie force-pushed the cylc-lint branch 2 times, most recently from ad7d68b to 6c0013d Compare February 1, 2024 16:34


def get_reference(linter, output_type):
def get_reference(linter: str, output_type: 'Literal["text", "rst"]') -> str:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/linter/ruleset?

@oliver-sanders oliver-sanders requested a review from wxtim February 7, 2024 16:43
@wxtim wxtim merged commit 7bf0b7a into cylc:master Feb 9, 2024
27 checks passed
@MetRonnie MetRonnie deleted the cylc-lint branch February 9, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lint: Use [tool.*] table within pyproject.toml
3 participants