-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new job var CYLC_WORKFLOW_NAME_BASE. #5009
Conversation
I've assigned myself to do a code review so that @dpmatthews doesn't have to, and so that @oliver-sanders only has to do a second review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Read
- Checked out locally, and successfully run the changed tests.
- 1 broken test - suggested fix in comment.
- Thank you for getting rid of all those
${CYLC_WORKFLOW_NAMES}
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments.
Co-authored-by: Tim Pillinger <[email protected]>
Opened docs PR - cylc/cylc-doc#506 |
Docs PR merged. One review OK for this. |
These changes close #4977
As requested: did not add
CYLC_WORKFLOW_NAME_DIR
Small compromise: I did not remove
CYLC_WORKFLOW_NAME
because taken together it's immediately clear what the new variable is the basename of.So now we have:
CYLC_WORKFLOW_ID
- e.g.a/b/c/run1
CYLC_WORKFLOW_NAME
- e.g.a/b/c
CYLC_WORKFLOW_NAME_BASE
- e.g.c
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
andconda-environment.yml
.