Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: support offsets in hold and stop after cycle points #5939

Closed
oliver-sanders opened this issue Jan 26, 2024 · 0 comments · Fixed by #5943
Closed

config: support offsets in hold and stop after cycle points #5939

oliver-sanders opened this issue Jan 26, 2024 · 0 comments · Fixed by #5943
Assignees
Milestone

Comments

@oliver-sanders
Copy link
Member

The final cycle point configuration supports offsets e.g:

final cycle point = 2000
final cycle point = 2000 + P1Y  # i.e. 2001
final cycle point = +P1Y  # i.e. "initial cycle point" + P1Y

However, the stop and hold cycle points do not.

It would be nice if these configs could work in the same way.

Context / why is this an 8.3.0 issue?

A common pattern in some areas is to run a workflow until it stops. Then modify the final cycle point to extend the workflow and restart.

This isn't an easy working pattern to port to Cylc 8 due to the difficulty of re-populating the start tasks. We have a plan to make this easier, see #5416, however, this working pattern is needlessly complex in the first place.

Swap final cycle point for stop after cycle point and the workflow never "completes" so the pool never needs re-polulating. This is much nicer for Cylc (no discontinuity), the user (no extra commands) and provenance (direct continuation of previous run).

@oliver-sanders oliver-sanders added this to the cylc-8.3.0 milestone Jan 26, 2024
@oliver-sanders oliver-sanders self-assigned this Jan 26, 2024
oliver-sanders added a commit to oliver-sanders/cylc-flow that referenced this issue Jan 29, 2024
* Closes cylc#5939
* Support offsets (measured from the ICP) for the `stop after cycle point`
  to mirror the behaviour of the `final cycle point`.
* Add integration test to lock-down `stop after cycle point`
* interactions.
oliver-sanders added a commit to oliver-sanders/cylc-flow that referenced this issue Jan 29, 2024
* Closes cylc#5939
* Support offsets (measured from the ICP) for the `stop after cycle point`
  to mirror the behaviour of the `final cycle point`.
* Add integration test to lock-down `stop after cycle point`
* interactions.
oliver-sanders added a commit to oliver-sanders/cylc-flow that referenced this issue Jan 29, 2024
* Closes cylc#5939
* Support offsets (measured from the ICP) for the `stop after cycle point`
  to mirror the behaviour of the `final cycle point`.
* Add integration test to lock-down `stop after cycle point`
  interactions.
oliver-sanders added a commit to oliver-sanders/cylc-flow that referenced this issue Jan 29, 2024
* Closes cylc#5939
* Support offsets (measured from the ICP) for the `stop after cycle point`
  to mirror the behaviour of the `final cycle point`.
* Add integration test to lock-down `stop after cycle point`
  interactions.
oliver-sanders added a commit to oliver-sanders/cylc-flow that referenced this issue Jan 30, 2024
* Closes cylc#5939
* Support offsets (measured from the ICP) for the `stop after cycle point`
  to mirror the behaviour of the `final cycle point`.
* Add integration test to lock-down `stop after cycle point`
  interactions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant