Add PrimaryServiceTemplate and ReplicaServiceTemplate#315
Closed
arosh wants to merge 1 commit intocybozu-go:mainfrom
Closed
Add PrimaryServiceTemplate and ReplicaServiceTemplate#315arosh wants to merge 1 commit intocybozu-go:mainfrom
arosh wants to merge 1 commit intocybozu-go:mainfrom
Conversation
arosh
force-pushed
the
primary-or-replica-service-template
branch
13 times, most recently
from
fd6c0e7 to
e1991a1
Compare
arosh
force-pushed
the
primary-or-replica-service-template
branch
from
e1991a1 to
1c0c635
Compare
Member
|
Let me close this. |
Member
Author
|
Resolved by #350 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In our Kubernetes cluster, we can automatically set desired external DNS name to the Service by annotating
external-dns.alpha.kubernetes.io/hostname.We want to set different annotations to the Service for primary instance and the Service for replica instances.
How
As a patch for
serviceTemplate,primaryServiceTemplateandreplicaServiceTemplatecan be specified in the manifest. They will be merged into theserviceTemplateapplied to the corresponding service and applied in the reconciliation loop.Matter of concern
The merging of
serviceTemplateandprimaryServiceTemplate/replicaServiceTemplateis implemented byDeepCopyInto. This behavior may confuse kustomize users.