Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supress dns log #790

Merged
merged 3 commits into from
Feb 19, 2025
Merged

Supress dns log #790

merged 3 commits into from
Feb 19, 2025

Conversation

chez-shanpu
Copy link
Contributor

@chez-shanpu chez-shanpu commented Feb 13, 2025

This PR supress DNS query logs for cluster-dns and node-dns.

cf.

@chez-shanpu chez-shanpu self-assigned this Feb 13, 2025
@chez-shanpu chez-shanpu marked this pull request as ready for review February 13, 2025 07:53
@chez-shanpu chez-shanpu requested a review from yokaze February 13, 2025 07:53
Copy link
Contributor

@yokaze yokaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks we need to remove the log plugin at op/clusterdns/clusterdns.go:20.

Only failed queries are logged with Combined Log Format.

Signed-off-by: Tomoki Sugiura <[email protected]>
disable query-by-query logging

Signed-off-by: Tomoki Sugiura <[email protected]>
@chez-shanpu chez-shanpu requested a review from yokaze February 17, 2025 08:19
@chez-shanpu chez-shanpu force-pushed the supress-dns-log branch 8 times, most recently from 2694c46 to 6952a50 Compare February 19, 2025 07:22
because of ZONE_RESOURCE_POOL_EXHAUSTED_WITH_DETAILS

Signed-off-by: Tomoki Sugiura <[email protected]>
Copy link
Contributor

@yokaze yokaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chez-shanpu chez-shanpu merged commit 8dc4a45 into main Feb 19, 2025
7 checks passed
@chez-shanpu chez-shanpu deleted the supress-dns-log branch February 19, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants